Rework playback architecture to use dispatcher #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 4, 2024 23:38
This is not entirely complete, some quirks exist, but it is intended to represent how a topic-specific events bridge can be used.
TLDR;
1. there are 2 initiators:
- initiated when progress bar is clicked
- initiated when verse is clicked ==> media_bridge.ex server issues seekTime
2. we can categorise events based on emitters / producers or consumers.
3. consumers generally consume events and generally only have internal
actions they carry out
4. sometimes, consumers may have external actions they carry out as
well. For example, if MediaBridge hook gets a server-initiated request
to seekTime, then it shall carry out internal actions (i.e. seekToS, as
well as pub the seekTimePayload to others via the seekTimeBridge)
This has some bugs, but the overall pattern should be correct. Also pending cleanups
rtshkmr
commented
Mar 7, 2024
assets/js/hooks/progress_bar.js
Outdated
| this.eventBridgeDeregisterers = { | ||
| seekTime: seekTimeDeregisterer, | ||
| heatbeat: heartbeatDeregisterer, | ||
| // playPause: playPauseDeregisterer, // FIXME @bala |
Visual Bug:Representation steps:
possible reasons:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.