Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consensus tests #626

Merged
merged 6 commits into from
Dec 20, 2023
Merged

Add consensus tests #626

merged 6 commits into from
Dec 20, 2023

Conversation

MakisChristou
Copy link
Member

This PR closes this issue by increasing the coverage of all files above 80%

block/block.go Outdated Show resolved Hide resolved
block/block.go Outdated Show resolved Hide resolved
block/block.go Outdated Show resolved Hide resolved
@MakisChristou
Copy link
Member Author

I have made some changes can you take a look @libotony ?

Copy link
Member

@libotony libotony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few improvement pieces of advice.

consensus/consensus_test.go Outdated Show resolved Hide resolved
consensus/consensus_test.go Outdated Show resolved Hide resolved
consensus/consensus_test.go Outdated Show resolved Hide resolved
consensus/consensus_test.go Outdated Show resolved Hide resolved
consensus/consensus_test.go Outdated Show resolved Hide resolved
MakisChristou and others added 5 commits December 20, 2023 09:22
Co-authored-by: libotony <liboliqi@gmail.com>
Co-authored-by: libotony <liboliqi@gmail.com>
Co-authored-by: libotony <liboliqi@gmail.com>
Co-authored-by: libotony <liboliqi@gmail.com>
Co-authored-by: libotony <liboliqi@gmail.com>
@libotony libotony merged commit 352fbc6 into vechain:master Dec 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants