Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pool:check executable against next block number #834

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

libotony
Copy link
Member

@libotony libotony commented Sep 3, 2024

Description

  • Allow TX valid on next block to propagate.(eg. head at 19, TX with ref 20)
  • Stops propagate TX that is expired on next block.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.51%. Comparing base (5b3db3a) to head (c3bab4f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #834      +/-   ##
==========================================
+ Coverage   62.50%   62.51%   +0.01%     
==========================================
  Files         208      208              
  Lines       18872    18872              
==========================================
+ Hits        11796    11798       +2     
+ Misses       5977     5975       -2     
  Partials     1099     1099              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@libotony libotony marked this pull request as ready for review September 19, 2024 09:59
@libotony libotony requested a review from a team as a code owner September 19, 2024 09:59
otherview
otherview previously approved these changes Sep 19, 2024
txpool/tx_object.go Outdated Show resolved Hide resolved
txpool/tx_object.go Outdated Show resolved Hide resolved
@libotony libotony merged commit fd5e569 into master Sep 20, 2024
17 checks passed
@libotony libotony deleted the tony/tune-txpool branch September 20, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants