Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pool: track pending cost per payer #845

Merged
merged 4 commits into from
Sep 25, 2024
Merged

pool: track pending cost per payer #845

merged 4 commits into from
Sep 25, 2024

Conversation

libotony
Copy link
Member

Description

Addresses vechain/protocol-board-repo#311

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 6 lines in your changes missing coverage. Please review.

Project coverage is 62.65%. Comparing base (fd5e569) to head (5644d7f).

Files with missing lines Patch % Lines
runtime/resolved_tx.go 57.14% 3 Missing ⚠️
txpool/tx_pool.go 81.25% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
+ Coverage   62.51%   62.65%   +0.13%     
==========================================
  Files         208      208              
  Lines       18872    18926      +54     
==========================================
+ Hits        11798    11858      +60     
+ Misses       5975     5970       -5     
+ Partials     1099     1098       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@libotony libotony marked this pull request as ready for review September 19, 2024 10:26
@libotony libotony requested a review from a team as a code owner September 19, 2024 10:26
Copy link
Member

@otherview otherview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. It looks good to me, only that concern around possible no-cost txs ?

runtime/resolved_tx.go Show resolved Hide resolved
txpool/tx_object_map.go Outdated Show resolved Hide resolved
txpool/tx_object_map.go Outdated Show resolved Hide resolved
txpool/tx_object_map.go Outdated Show resolved Hide resolved
txpool/tx_object_map.go Show resolved Hide resolved
txpool/tx_object_map.go Show resolved Hide resolved
txpool/tx_object_map.go Outdated Show resolved Hide resolved
txpool/tx_object_map.go Outdated Show resolved Hide resolved
@libotony libotony merged commit 56bd50e into master Sep 25, 2024
17 checks passed
@libotony libotony deleted the tony/pending-cost branch September 25, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants