Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new gosec gh yaml file #846

Merged
merged 6 commits into from
Sep 17, 2024
Merged

Add new gosec gh yaml file #846

merged 6 commits into from
Sep 17, 2024

Conversation

paologalligit
Copy link
Member

Description

Add new workflow for gosec when creating PRs to master and when merging into master.

GH Issue

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@paologalligit paologalligit requested a review from a team as a code owner September 12, 2024 09:35
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.51%. Comparing base (5bc66a8) to head (1556b1a).

Files with missing lines Patch % Lines
cache/rnd_cache.go 50.00% 1 Missing ⚠️
comm/peer.go 0.00% 1 Missing ⚠️
p2psrv/rpc/rpc.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #846   +/-   ##
=======================================
  Coverage   62.51%   62.51%           
=======================================
  Files         208      208           
  Lines       18872    18872           
=======================================
  Hits        11798    11798           
  Misses       5975     5975           
  Partials     1099     1099           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@otherview otherview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

go-version: '1.22'
cache: false
- name: Run Gosec
uses: securego/gosec@master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is always running at the latest version of GoSec yeah ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's also the suggest way to structure the job taken from the gosec page

@paologalligit paologalligit merged commit 5b3db3a into master Sep 17, 2024
17 checks passed
@paologalligit paologalligit deleted the paolo/chore/gosec branch September 17, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants