-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fees/priority
endpoint
#984
Open
freemanzMrojo
wants to merge
19
commits into
release/galactica
Choose a base branch
from
feat/fees-priority
base: release/galactica
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feat/fees-priority
…nto feat/fees-priority
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/galactica #984 +/- ##
=====================================================
+ Coverage 62.14% 62.16% +0.02%
=====================================================
Files 226 226
Lines 23498 23570 +72
=====================================================
+ Hits 14603 14653 +50
- Misses 7761 7779 +18
- Partials 1134 1138 +4 ☔ View full report in Codecov by Sentry. |
darrenvechain
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This endpoint is a version of
eth_maxPriorityFeePerGas
.Interface-wise is the same, and the parameters are based on go-ethereum except for the max priority fee cap (500 gwei in Eth, we do not have a reference figure yet). The other difference is that all the params are internal and non-configurable (in geth they use also flags, we can do the same but I prefer to comment it over the PR).
Re-uses the cache logic of the other
fees
endpoint so the common cache is built by any of these endpoints.Added a new integration test for this endpoint, further testing will be done as part of the follow-up ticket regarding parameters. Checked though that the priority fees array is built as expected.
Closes https://github.com/vechain/protocol-board-repo/issues/390