#324 - Rename setTrackedModel to trackModel #329
Conversation
mandragorn
force-pushed
the
324
branch
2 times, most recently
from
61e12f4 to
f349d29
Compare
| */ | ||
| setTrackedModel: function(alias, model, copy) { | ||
| this.trackModel(alias, model, copy); |
There was a problem hiding this comment.
I'd rather not have to maintain deprecated arguments. See https://github.com/vecnatechnologies/backbone-torso/blob/master/modules/View.js#L104
There was a problem hiding this comment.
yea I was thinking about that. I'll update it.
| */ | ||
| setTrackedModel: function(alias, model, copy) { | ||
| setTrackedModel: function() { |
There was a problem hiding this comment.
oh man, i should have said the first time to reference the newer method's javadoc instead of copying pasting it. up to you if you want to update it or merge it.
There was a problem hiding this comment.
can you link the doc of another method with yuidoc?
There was a problem hiding this comment.
Yea, at least in the old fashion way of saying go check out the documentation on this other method. Still way better than managing both javadocs
|
Can we resolve/merge this before the next version gets published today? |
|
@kentmw is there a problem upgrading to backbone 1.3.3 with this? My local build with yarn is being annoying if I don't (multiple versions of backbone). |
|
The changelog sounds like only good stuff. I'd say go for it.
…On Wed, Sep 6, 2017 at 9:37 AM, Josh Young ***@***.***> wrote:
@kentmw <https://github.com/kentmw> is there a problem upgrading to
backbone 1.3.3 with this? My local build with yarn is being annoying if I
don't (multiple versions of backbone).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#329 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAaBnBF63j4snRP6jr_ilqWoWo0G9C3nks5sfqAngaJpZM4N4v7a>
.
|
Renamed so that the method names are consistent with existing methods. Old versions left for backwards compatibility.
|
@kentmw - I updated the docs should be good for final review. |
No description provided.