-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unignore user must perform an initial sync #5767
Conversation
@@ -634,7 +634,7 @@ | |||
<string name="room_participants_action_ignore">Ignore</string> | |||
|
|||
<string name="room_participants_action_unignore_title">Unignore user</string> | |||
<string name="room_participants_action_unignore_prompt_msg">Unignoring this user will show all messages from them again.</string> | |||
<string name="room_participants_action_unignore_prompt_msg">Unignoring this user will show all messages from them again.\n\nNote that this action will restart the app and it may take some time.</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is OK not to create a new string. The translations will be updated one by one, but the use case is not performed a lot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks fine. We need the Initial Sync in order to fetch already ignored messages? or there is another reason?
Thanks for your fast review!
Yes, the server does not send the message from ignored users to the client. So once the account data is updated, we have to perform a new complete sync. |
Type of change
Content
Displaying a confirmation dialog when a user is unignored, and perform an init sync when it's done:
Motivation and context
Closes #3439
Screenshots / GIFs
Tests
Tested devices
Checklist