Excluding legacy support library annotation usages #7140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouchadam
requested review from
a team and
Florian14
and removed request for
a team
6 tasks
- The library exports a jetified artifact but doesn't remove the support library dependency /home/adam/dev/element/element-android/vector/build.gradle
ouchadam
force-pushed
the
feature/adm/legacy-support-library-usages
branch
from
b78240e to
ae50f5a
Compare
…ules also get the exclusion - also excludes the support dependency from the barcode scanner
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
progressPieIndicatordependencyandroid-scalablevideoview, the library is pre-jetified but includes a redundant legacy support library transitive dependencyMotivation and context
The time has come to avoid using the Jetifier (the process of converting libraries from the legacy support library to androidx). The
Paparazziintegration is blocked due to the plugin requiring the jetifier to be disabled for the base android libraries which causes the unit tests with android imports to fail.There is one more library to update
im.dlg:android-dialer:1.2.5which will need to be manually included as the upstream project no longer exists, although it's mainly a wrapper around legacy AOSP classes.Will slightly speed up the build and may improve the cachability of the module dependencies (as they'll be statically cached from their maven repositories)
Screenshots / GIFs
No UI changes
Tests
Smoke test around the app
Tested devices