Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paparazzi screenshot testing setup #7128

Merged
merged 14 commits into from
Sep 26, 2022
Merged

Paparazzi screenshot testing setup #7128

merged 14 commits into from
Sep 26, 2022

Conversation

ouchadam
Copy link
Contributor

@ouchadam ouchadam commented Sep 14, 2022 •
edited
Loading

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Includes Paparazzi into the project and tests CI pipeline
    • Adds top level gradle tasks recordScreenshots and verifyScreenshots
  • Sets up git lfs with CI check to ensure files are committed correctly
  • Adds documentation on how to use Paparazzi

Motivation and context

Part of #5798

#7128 - Example test
#7137 - Test failure

Tests

N/A (there's a test showcase PR up next)

Tested devices

  • Physical
  • Emulator
  • OS version(s):

ouchadam
ouchadam commented Sep 14, 2022
View reviewed changes
.github/workflows/validate-lfs.yml
@@ -0,0 +1,15 @@
name: Validate Git LFS
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github action to validate committed screenshots are done with git lfs

@ouchadam ouchadam mentioned this pull request Sep 14, 2022
Merged
5 tasks
@ouchadam ouchadam requested review from a team and fedrunov and removed request for a team September 15, 2022 08:41
@ouchadam ouchadam marked this pull request as ready for review September 15, 2022 08:41
@ouchadam ouchadam force-pushed the feature/adm/screenshot-testing-setup branch from 1c94206 to 27728bf Compare September 15, 2022 15:42
@ouchadam
Copy link
Contributor Author

Added blocked label, this change relies on #7140 and #7142

@ouchadam ouchadam force-pushed the feature/adm/screenshot-testing-setup branch from 27728bf to 92a3bf1 Compare September 16, 2022 14:35
@ouchadam ouchadam changed the base branch from develop to base/no-support-libs September 16, 2022 14:35
@ouchadam ouchadam force-pushed the feature/adm/screenshot-testing-setup branch 2 times, most recently from 27728bf to c50faf8 Compare September 16, 2022 15:15
@ouchadam ouchadam changed the base branch from base/no-support-libs to develop September 26, 2022 09:19
@ouchadam
adding paparazzi screenshot testing lib setup
c66a380
@ouchadam
including git lfs config for picking up screenshot test recordings
9fd7704
@ouchadam
adding github action to validate screenshot files are commited with g…
9ef4975 
…it lfs
@ouchadam
creating custom tasks to record and verify screenshot
0f19726 
- introduces a 'screenshot' flag to include/exclude the screenshot tests from the default test runs
@ouchadam
ignoring the screenshot failure results from git
7f8cb4b
@ouchadam
including screenshot verification and error result uploads as part of…
b0e2596 
… the test step
@ouchadam
including lfs files when checking out during tests workflow
243ca01
@ouchadam
adding docs for creating, recording and verifying screenshot tests
c19b359
@ouchadam
adding origin of bash script url
1fab6e6
@ouchadam
adding changelog entry
469dd46
@ouchadam
using ## heading for the examples block
7740404
@ouchadam
adding missing colon to yml run param
7d18d89
@ouchadam
removing jetifier screenshot config as the jetifier is no longer needed
dc0599f
@ouchadam
making use of the lazy task registration to allow only applying the p…
c0baa2e 
…aparazzi plugin when needed
@ouchadam ouchadam force-pushed the feature/adm/screenshot-testing-setup branch from c50faf8 to c0baa2e Compare September 26, 2022 09:26
@ouchadam ouchadam enabled auto-merge September 26, 2022 09:26
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ouchadam ouchadam merged commit 59e7b70 into develop Sep 26, 2022
@ouchadam ouchadam deleted the feature/adm/screenshot-testing-setup branch September 26, 2022 11:01
@ouchadam ouchadam mentioned this pull request Sep 27, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedrunov fedrunov fedrunov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ouchadam @fedrunov