Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ignore] Forcing the screenshot test to fail #7137

Closed
wants to merge 1 commit into from
Closed

[Ignore] Forcing the screenshot test to fail #7137

wants to merge 1 commit into from

Conversation

ouchadam
Copy link
Contributor

Showcasing how screenshot test failures present themselves - As artifacts of the tests.yml workflow

@ouchadam ouchadam mentioned this pull request Sep 15, 2022
Merged
6 tasks
@ouchadam ouchadam force-pushed the feature/adm/screenshot-testing-example-test branch from 7fb2624 to 2d64886 Compare September 16, 2022 15:26
@ouchadam ouchadam force-pushed the feature/adm/screenshot-testing-example-failing-test branch from 5ede807 to 6c634be Compare September 16, 2022 15:27
@ouchadam ouchadam force-pushed the feature/adm/screenshot-testing-example-test branch 3 times, most recently from 9022acf to 4a81ee2 Compare September 26, 2022 14:13
@ouchadam ouchadam force-pushed the feature/adm/screenshot-testing-example-failing-test branch from 6c634be to 558c4b9 Compare September 27, 2022 07:57
@bmarty
Copy link
Member

bmarty commented Sep 27, 2022

The CI seems happy?

@ouchadam
Copy link
Contributor Author

@bmarty yeah it's strange.. I'm looking into it, changing the text to fail1 fails the test but not fail or empty

@ouchadam ouchadam force-pushed the feature/adm/screenshot-testing-example-failing-test branch from 558c4b9 to bc5db68 Compare September 27, 2022 09:35
@ouchadam ouchadam mentioned this pull request Sep 27, 2022
Merged
5 tasks
@ouchadam ouchadam force-pushed the feature/adm/screenshot-testing-example-failing-test branch from bc5db68 to f299615 Compare September 27, 2022 10:07
@ouchadam
Copy link
Contributor Author

@bmarty yeah it's strange.. I'm looking into it, changing the text to fail1 fails the test but not fail or empty

turns out this was due to the maxPercentDifference option defaulting to 0.1%, dropping to 0% catches the changes but has the risk failing due to navigation and status bar pixel rendering quirks (will need to monitor)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ouchadam
Copy link
Contributor Author

Tests are failing and the artifacts are correctly uploaded https://github.com/vector-im/element-android/actions/runs/3134733720 (can close!)

@ouchadam ouchadam closed this Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ouchadam @bmarty