-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore macOs room header dragability #1136
Conversation
.mx_RoomHeader .mx_E2EIcon, | ||
.mx_RoomHeader .mx_RoomTopic, | ||
.mx_RoomHeader .mx_AccessibleButton { | ||
.mx_RoomHeader .mx_DecoratedRoomAvatar, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text container for the room name in the room header should also be no-drag, like it is on legacy (its within the Accessible Button)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure it needs to be like that.
The new room header is not interactive the same way the old one way, therefore we can allow drag from that element.
In the spirit of moving that pull request forward i've pushed that change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd mean you can't highlight the text which is not good for accessibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
Cross posting what I added to #element-dev:matrix.org
|
Fixes #1135
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes