Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exit shortcuts for non QWERTY keyboards #185

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

germain-gg
Copy link
Contributor

Fixes element-hq/element-web#16938

I was unfortunately using KeyboardEvent.code. When reading through the MDN documentation there is a fair warning saying

Warning: This ignores the user's keyboard layout, so that if the user presses the key at the "Y" position in a QWERTY keyboard layout (near the middle of the row above the home row), this will always return "KeyY", even if the user has a QWERTZ keyboard (which would mean the user expects a "Z" and all the other properties would indicate a "Z") or a Dvorak keyboard layout (where the user would expect an "F").

@germain-gg germain-gg requested a review from a team April 15, 2021 15:52
@germain-gg germain-gg merged commit 5ae736e into develop Apr 15, 2021
@germain-gg germain-gg deleted the gsouquet-exit-shortcut branch April 15, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⌘A on AZERTY keyboards open "Close Element" Popup
2 participants