Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Odd error message in Space member list #4845

Closed
kittykat opened this issue Sep 16, 2021 · 4 comments
Closed

Odd error message in Space member list #4845

kittykat opened this issue Sep 16, 2021 · 4 comments
Assignees
@kittykat @gileluard
Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Release-Blocker Z-Spaces-Testing

Comments

@kittykat
Copy link
Contributor

kittykat commented Sep 16, 2021 •
edited
Loading

Steps to reproduce

  1. Go to a Space and then member list (person icon at the bottom of the screen)
  2. Press the + icon bottom right
  3. On the "Members" view, press the bottom right + icon again

What happened?

What did you expect?

Error message to say what the feature is because I'm not sure what I'm failing to do.

This button shouldn't be there for the release

What happened?

image

Your phone model

No response

Operating system version

No response

Application version

1.5.4 (Gil's version for testing spaces)

Homeserver

No response

Have you submitted a rageshake?

No
@kittykat kittykat added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Spaces Spaces, groups, communities S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely Z-Spaces-Testing X-Release-Blocker labels Sep 16, 2021
@gileluard
Copy link
Contributor

@niquewoodhouse I need some advice as it works as designed.

@niquewoodhouse
Copy link

niquewoodhouse commented Sep 16, 2021 •
edited
Loading

@niquewoodhouse I need some advice as it works as designed.

Yes it is, so I don't believe this needs to be removed. I'd just like to tweak the copy.

In design I decided to leave the invite button in its usual place on iOS so people can actually see how to add someone later (when the feature is in iOS). Or I believe people will feel lost on what to do and we'll be fielding endless questions on how to do it on iOS.

@gileluard My suggestion is changing the copy to be specific to invite flow if possible.

  • Invites coming soon Coming soon

It might be worth @vector-im/product (eg @daniellekirkwood @nadonomy) checking if they agree with the strategy before deciding what to do.

@nadonomy
Copy link
Contributor

Happy to defer to yourselves @niquewoodhouse & @daniellekirkwood on this one.

@kittykat
Copy link
Contributor Author

The tweak would fix my concern and I would consider it resolved

gileluard added a commit that referenced this issue Sep 20, 2021
@gileluard
[spaces] several fixes for pre release
c1a542e 
- [Space home view inherits title from previously viewed tab](#4851)
- [Home view doesn't refresh when new rooms are created](#4849)
- [Odd error message in Space member list](#4845)
- [Bring leaving space experience in line with Web](#4850)
- [No notification for space invitation](#4840)
- [Remove filter when space is switched](#4852)
- [M10.11 Remove community tab](#4493)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittykat kittykat

@gileluard gileluard

Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Release-Blocker Z-Spaces-Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kittykat @niquewoodhouse @nadonomy @gileluard