Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concurrency to GitHub actions #5039

Closed
3 tasks done
pixlwave opened this issue Oct 22, 2021 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1505
Closed
3 tasks done

Add concurrency to GitHub actions #5039

pixlwave opened this issue Oct 22, 2021 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1505
Labels
A-Developer-Experience T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Comments

@pixlwave
Copy link
Member

pixlwave commented Oct 22, 2021

Currently our actions run on the creation of a PR, and then every commit that gets added to the PR. However they stack so that making lots of small commits (e.g. via GitHub's review suggestions) creates a huge queue and slows CI down for everybody. We can add the concurrency parameter along with cancel-in-progress (docs) to the workflows to automatically cancel running tasks when a new one comes in.

Note: As our actions are shared for both PRs and pushing to develop, we should consider whether we also want the same behaviour on develop if multiple PRs are merged into develop quickly.

@pixlwave pixlwave added A-Developer-Experience T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Developer-Experience T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant