Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh Room Activity Indicators #5603

Closed
Anderas opened this issue Feb 16, 2022 · 4 comments · Fixed by #5690
Closed

Refresh Room Activity Indicators #5603

Anderas opened this issue Feb 16, 2022 · 4 comments · Fixed by #5690
Assignees
@Anderas
Labels
A-Activity-Indicators Unifying the activity indicator style across the app T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-WTF WTF issues: High impact, Low Effort

Comments

@Anderas
Copy link
Contributor

Anderas commented Feb 16, 2022 •
edited
Loading

Replace legacy activity indicators with updated ones for entering an existing room. See #4829 for further context.

  • consider dark mode
  • overlap with "jump to unread"
  • consider home vs room indicators on iPads

Figma designs
@Anderas Anderas added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Activity-Indicators Unifying the activity indicator style across the app labels Feb 16, 2022
@Anderas Anderas mentioned this issue Feb 16, 2022
Open
@Anderas
Copy link
Contributor Author

Anderas commented Feb 16, 2022

Pay attention to the fact that other UI may be obscuring / be obscured by the loading indicator, eg "jump to unread"

Simulator Screen Shot - iPhone 13 - 2022-02-16 at 11 28 13

@daniellekirkwood daniellekirkwood added Z-WTF WTF issues: High impact, Low Effort X-Needs-Design May require input from the design team labels Feb 22, 2022
@daniellekirkwood
Copy link
Contributor

@amshakal to suggest how to move the 2 indicators. Also need info for Dark Mode and iPad things...

@Anderas Anderas mentioned this issue Feb 22, 2022
Merged
@amshakal
Copy link

amshakal commented Feb 22, 2022 •
edited
Loading

  1. Dark Mode: Added a subtle drop shadow to the indicator for dark mode. Link to figma

Screenshot 2022-02-22 at 7 14 32 pm

  1. Overlap with "jump to unread": Is it possible to hide jump to under while it's syncing or loading? Or would there still be situations where showing both will be a hard requirement?

  2. Home vs Room indicators: I think I need more context to provide direction on this

@Anderas
Copy link
Contributor Author

Anderas commented Feb 23, 2022 •
edited
Loading

Thanks @amshakal

  1. I've added you as a reviewer to Enable home activity indicator #5665 which contains some dark mode previews, but the shadow clearly needs to be more prominent
  2. I will try this out unless the complexity is too high
  3. Home vs Room on iPad means we might have to show potentially two spinners at once as on this screenshot. Personally it makes sense to me, if you are okay with it (ignore the loading in the middle of the screen, only the two around navigation bars).

Screenshot 2022-02-22 at 13 43 04

@Anderas Anderas assigned Anderas and unassigned amshakal Feb 23, 2022
@Anderas Anderas removed the X-Needs-Design May require input from the design team label Feb 23, 2022
@Anderas Anderas mentioned this issue Feb 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Anderas Anderas

Labels
A-Activity-Indicators Unifying the activity indicator style across the app T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-WTF WTF issues: High impact, Low Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Room activity indicators element-hq/element-ios
3 participants
@Anderas @amshakal @daniellekirkwood