Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Invite people"to the space menu in the left panel and update menu order #5810

Closed
Tracked by #164
kittykat opened this issue Mar 11, 2022 · 11 comments · Fixed by #5897
Closed
Tracked by #164

Add "Invite people"to the space menu in the left panel and update menu order #5810

kittykat opened this issue Mar 11, 2022 · 11 comments · Fixed by #5897
Assignees
Labels
A-Spaces Spaces, groups, communities T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Team: Delight Z-IA Issues relating to information architecture Z-Labs

Comments

@kittykat
Copy link
Contributor

When you open left panel -> ⋯ menu for a Space, the first item in the list should be "Invite people", like on Android.

The menu order should be:

  • Invite people
  • Explore rooms
  • Members
  • Settings
  • Add room
  • Add space
  • Leave

Current screenshots:

  • iOS:
    ima_d810d9a
  • Android:
    Screenshot_20220308-163330
@kittykat kittykat added A-Spaces Spaces, groups, communities Z-IA Issues relating to information architecture Team: Delight labels Mar 11, 2022
@kittykat kittykat added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Mar 11, 2022
@gileluard
Copy link
Contributor

@niquewoodhouse @kittykat quick questions:

  • on iOS the copy is Members and on android List members. Do you want to change it?
  • on small screens the user needs to scroll to see the leave item. I can reduce the height of each menu item if you want
  • Just to make sure, selecting Invite People obviously opens the invite screen for the space

Here is a short screen record:
ezgif-5-2de14a35a6

@kittykat
Copy link
Contributor Author

  • on iOS the copy is Members and on android List members. Do you want to change it?

No, it should be "Members" (Android has a PR in review to fix that)

  • on small screens the user needs to scroll to see the leave item. I can reduce the height of each menu item if you want

-> Nique for decision

I think it's better to make it shorter, but it's also important to fit in with other parts of the app.

  • Just to make sure, selecting Invite People obviously opens the invite screen for the space

Yes and to be clear, the "Invite people" option should be available even on spaces where the user isn't an admin but can still share the link or invite other users in some way.

@gileluard
Copy link
Contributor

Good point. I followed the same UX strategy: the "Invite people" option is displayed but an alert is displayed if the user doesn't have enough right to invite people. Note that this is the exact behaviour we already have in the space members screen:

ezgif-1-6d37c976e9

@kittykat
Copy link
Contributor Author

FYI, on Android we hide it atm if the user doesn't have permissions to invite

@gileluard
Copy link
Contributor

to confirmed by @niquewoodhouse but I understood that is the chosen strategy all over the app.

@niquewoodhouse
Copy link

to confirmed by @niquewoodhouse but I understood that is the chosen strategy all over the app.

That was for while you couldn't do anything additive to a space in the app for iOS. So adding a room, inviting people. We thought all feedback would be "how do I add someone/a room". Now it seems like you'll be able to invite people to spaces you have the rights to? So now iOS needs to reflect Android and remove that option if user doesn't have permission.

on small screens the user needs to scroll to see the leave item. I can reduce the height of each menu item if you want

If we do this what happens if user has dynamic type? I'd rather we leave them whatever size they are now and making such sheets better is an IA issue, so they're consistent. I think it would be strange to experience a smaller menu here but bigger elsewhere.

@niquewoodhouse
Copy link

to confirmed by @niquewoodhouse but I understood that is the chosen strategy all over the app.

That was for while you couldn't do anything additive to a space in the app for iOS. So adding a room, inviting people. We thought all feedback would be "how do I add someone/a room". Now it seems like you'll be able to invite people to spaces you have the rights to? So now iOS needs to reflect Android and remove that option if user doesn't have permission.

Just to add, I think this could be a follow up issue if we need to get this out in this RC - what do you think @kittykat

@gileluard
Copy link
Contributor

gileluard commented Mar 22, 2022

This is not consistent with other screens in my opinion:

matrix-org/matrix-ios-sdk#1328 (comment)
#5230 (comment)

@gileluard
Copy link
Contributor

We'll need to rework Home, timeline, space members and explore room screens in this case if we want to be consistent.

@niquewoodhouse
Copy link

We'll need to rework Home, timeline, space members and explore room screens in this case if we want to be consistent.

In that case, I think we should move this kind of work into IA and not spaces (how do we treat things across app when user has not enough rights/permissions) and leave it as is wdyt @kittykat ?

@kittykat
Copy link
Contributor Author

Agreed, we can review the interactions as part of IA rather than Spaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spaces Spaces, groups, communities T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Team: Delight Z-IA Issues relating to information architecture Z-Labs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants