Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Riot-Defaults out of property lists #6273

Closed
aringenbach opened this issue Jun 13, 2022 · 0 comments · Fixed by #6373
Closed

Move Riot-Defaults out of property lists #6273

aringenbach opened this issue Jun 13, 2022 · 0 comments · Fixed by #6373
Labels
A-Settings A-User-Settings T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@aringenbach
Copy link
Contributor

Your use case

Currently some Defaults are defined inside Riot-Defaults.plist, these would be better off somewhere else.

We need to be extra careful on migration because some of these defaults might be already set in RiotSettings.defaults with unexpected/historic values due to this migration: https://github.com/vector-im/element-ios/blob/10f250d7cd29a92cc257f5e07ae667580d27c946/Riot/Managers/Settings/RiotSettings.swift#L56

Have you considered any alternatives?

No

Additional context

This came up as an issue upon updating one of these defaults here: #6272

@aringenbach aringenbach added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-User-Settings A-Settings labels Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Settings A-User-Settings T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant