Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes to localisation #6011

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Small changes to localisation #6011

merged 1 commit into from
Apr 8, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Apr 8, 2022

This PR adds a few small changes following on from #5936 and #5996.

  • The NOTIFICATION key has been renamed to Notification as this is what will be shown for languages without a translation of this key.
  • Bundle.app is now a stored property as its value isn't going to change and we're using it every time we load a string.
  • The Pirate language has been excluded from the project as it generates a warning when submitting to ASC 🏴‍☠️

Note: I've synced with Weblate and locked it for now to avoid any conflicts with the change in the translations.

Make Bundle.app a stored property.
Exclude Pirate from the supported languages.
@pixlwave pixlwave requested review from a team and SBiOSoftWhare and removed request for a team April 8, 2022 13:15
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pnjUJh

@pixlwave pixlwave merged commit 73815ef into develop Apr 8, 2022
@pixlwave pixlwave deleted the doug/localisation branch April 8, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants