Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dedicated HTMLFormatter and improve post format operations performance #6261

Merged
merged 6 commits into from
Jun 16, 2022
Merged

Use dedicated HTMLFormatter and improve post format operations performance #6261

merged 6 commits into from
Jun 16, 2022

Conversation

aringenbach
Copy link
Contributor

@aringenbach aringenbach commented Jun 9, 2022 •
edited
Loading

This improves the existing HTMLFormatter and HTML formatting performance by:

  • Rebranding the HTMLFormatter in a full Swift implementation with a working fix for DTCoreText EXC_BAD_ACCESS issues
  • Reusing the HTMLFormatter in MXKEventFormatter
  • Reduce greatly the number of back-to-back NSMutableAttributedString allocations (this could be improved further but this already should be a good starter)

@github-actions
Copy link

github-actions bot commented Jun 9, 2022 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/1v9MdH

@aringenbach aringenbach changed the title Improve HTML formatter Use dedicated HTMLFormatter and improve post format operations performance Jun 10, 2022
@aringenbach aringenbach requested review from a team, phloux and MaximeEvrard42 and removed request for a team June 10, 2022 13:19
phloux
phloux reviewed Jun 13, 2022
View reviewed changes
Copy link
Contributor

@phloux phloux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems good for me, but I still have building issues on my side.

@aringenbach aringenbach mentioned this pull request Jun 14, 2022
Merged
MaximeEvrard42
MaximeEvrard42 approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@MaximeEvrard42 MaximeEvrard42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@aringenbach aringenbach merged commit 8fdf3d8 into develop Jun 16, 2022
@aringenbach aringenbach deleted the aringenbach/improve_html_formatter branch June 16, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximeEvrard42 MaximeEvrard42 MaximeEvrard42 approved these changes

@phloux phloux phloux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aringenbach @phloux @MaximeEvrard42