Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore the voice broadcast chunks at the notifications level #7230

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Jan 4, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 11.83% // Head: 11.83% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (44d2b4b) compared to base (a8e2ec0).
Patch has no changes to coverable lines.

❗ Current head 44d2b4b differs from pull request most recent head 0ff9c94. Consider uploading reports for the commit 0ff9c94 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7230      +/-   ##
===========================================
- Coverage    11.83%   11.83%   -0.01%     
===========================================
  Files         1629     1630       +1     
  Lines       160157   160252      +95     
  Branches     65390    65439      +49     
===========================================
+ Hits         18962    18973      +11     
- Misses      140558   140641      +83     
- Partials       637      638       +1     
Flag Coverage Δ
uitests 54.86% <ø> (+0.02%) ⬆️
unittests 5.96% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ules/Room/TimelinePoll/View/TimelinePollView.swift 71.64% <0.00%> (-0.94%) ⬇️
...linePoll/View/TimelinePollAnswerOptionButton.swift 54.16% <0.00%> (-0.46%) ⬇️
.../Modules/MatrixKit/Models/Room/MXKRoomDataSource.m 12.98% <0.00%> (-0.04%) ⬇️
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
Riot/Modules/Room/CellData/RoomBubbleCellData.m 0.00% <0.00%> (ø)
...es/Room/VoiceMessages/VoiceMessageController.swift 0.00% <0.00%> (ø)
...es/Room/TimelinePoll/TimelinePollScreenState.swift 100.00% <0.00%> (ø)
...linePoll/Coordinator/TimelinePollCoordinator.swift 0.00% <0.00%> (ø)
...r/Coordinator/VoiceBroadcastRecorderProvider.swift 0.00% <0.00%> (ø)
...oordinator/VoiceBroadcastRecorderCoordinator.swift 0.00% <0.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yostyle yostyle force-pushed the yostyle/voicebroadcast_notifications branch from 4089b62 to d620705 Compare January 6, 2023 19:21
@yostyle yostyle marked this pull request as ready for review January 6, 2023 21:24
@yostyle yostyle force-pushed the yostyle/voicebroadcast_notifications branch 2 times, most recently from d8697a8 to 3b6639b Compare January 6, 2023 21:28
@yostyle yostyle force-pushed the yostyle/voicebroadcast_notifications branch from 3b6639b to 16c03c9 Compare January 6, 2023 21:28
Copy link
Contributor

@phloux phloux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I cannot test it.

@yostyle
Copy link
Contributor Author

yostyle commented Jan 9, 2023

LGTM, but I cannot test it.

@phlniji you could test on a physical device with element target.

Copy link
Contributor

@nimau nimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't have any VB notifications anymore.

@yostyle yostyle force-pushed the yostyle/voicebroadcast_notifications branch from 44d2b4b to 0ff9c94 Compare January 10, 2023 09:28
@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yostyle yostyle merged commit 4cb21f7 into develop Jan 10, 2023
@yostyle yostyle deleted the yostyle/voicebroadcast_notifications branch January 10, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants