Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new RoomListService::sync_indicator api #1244

Closed
bmarty opened this issue Sep 7, 2023 · 0 comments · Fixed by #1257
Closed

Use the new RoomListService::sync_indicator api #1244

bmarty opened this issue Sep 7, 2023 · 0 comments · Fixed by #1257
Assignees
@ganfra
Labels
A-Room List T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Comments

@bmarty
Copy link
Member

bmarty commented Sep 7, 2023

It should replace observing the usage of RoomListService.state to display the loading banner on the room list.

Do not replace the usage of RoomListService.state for the Migration screen since there is an internal delay RoomListService::sync_indicator

FTR Rust PR: matrix-org/matrix-rust-sdk#2518
@bmarty bmarty added T-Task Refactoring, enabling or disabling functionality, other engineering tasks A-Room List Z-Schedule labels Sep 7, 2023
@ganfra ganfra self-assigned this Sep 7, 2023
@ganfra ganfra mentioned this issue Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ganfra ganfra

Labels
A-Room List T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/fga/sync indicator api element-hq/element-x-android
2 participants
@bmarty @ganfra