Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rich text editor] Fix placeholder spilling onto multiple lines #1347

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Sep 15, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Fix rich text editor placeholder spilling onto multiple lines.

Motivation and context

The French translation for the editor placeholder is verbose and may spill onto multiple lines if not truncated.

Screenshots / GIFs

Tests

Tested manually by substituting the placeholder with long text.

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 13

Checklist

@jonnyandrew jonnyandrew marked this pull request as ready for review September 15, 2023 10:15
@jonnyandrew jonnyandrew requested a review from a team as a code owner September 15, 2023 10:15
@jonnyandrew jonnyandrew requested review from ganfra and removed request for a team September 15, 2023 10:15
@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/VaMP1Q

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6563dca) 57.91% compared to head (0b71881) 57.92%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1347   +/-   ##
========================================
  Coverage    57.91%   57.92%           
========================================
  Files         1109     1109           
  Lines        29256    29258    +2     
  Branches      5976     5976           
========================================
+ Hits         16945    16947    +2     
  Misses        9683     9683           
  Partials      2628     2628           
Files Changed Coverage Δ
...ent/android/libraries/textcomposer/TextComposer.kt 54.71% <100.00%> (+0.24%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmarty bmarty merged commit 4a6ce3f into develop Sep 15, 2023
14 of 15 checks passed
@bmarty bmarty deleted the jonny/fix-placeholder-overflow branch September 15, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants