Use the right protocol for SSO URLs #14513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
approved these changes
Jul 16, 2020
Closed
jaller94
reviewed
Jul 16, 2020
| @@ -502,7 +502,7 @@ export default class ElectronPlatform extends VectorBasePlatform { | |||
|
|
|||
| getSSOCallbackUrl(fragmentAfterLogin: string): URL { | |||
| const url = super.getSSOCallbackUrl(fragmentAfterLogin); | |||
| url.protocol = "riot"; | |||
| url.protocol = "element"; | |||
| url.searchParams.set("riot-desktop-ssoid", this.ssoID); | |||
There was a problem hiding this comment.
This stays "riot-desktop-ssoid" for compatibility?
There was a problem hiding this comment.
good catch - will get this fixed
refi64
added a commit
to refi64/riot-web-lc
that referenced
this pull request
Jul 17, 2020
[Full Changelog](element-hq/element-web@v1.7.0...v1.7.1) * Upgrade to React SDK 2.10.1 * Fix SSO session ID paramater [\element-hq#14544](element-hq#14544) * Run pngcrush on vector-icons [\element-hq#14488](element-hq#14488) * Fix hosting signup link [\element-hq#14502](element-hq#14502) * Use the right protocol for SSO URLs [\element-hq#14513](element-hq#14513) * Fix mstile-310x150 by renaming it [\element-hq#14485](element-hq#14485) * Update blog and twitter links to point to Element [\element-hq#14478](element-hq#14478)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14517