Adjust CSS to prevent scrollbars on message panel spinner #6131
Conversation
when clicking on permalinks/jump to first
| @@ -113,8 +118,6 @@ limitations under the License. | |||
| max-width: 960px; | |||
| margin: auto; | |||
|
|
|||
| min-height: 100%; | |||
There was a problem hiding this comment.
this worries me - isn't the min-height the only thing keeping the timeline contents pushed to the bottom of the page if the room's history is just starting off?
There was a problem hiding this comment.
I could have sworn I fixed this failure mode, but it seems to have been left out again. I'll try to fix it.
There was a problem hiding this comment.
Right, now I remember. I made the .mx_messagePanelSpinner specifically so that mx_RoomView_messageListWrapper could happily, separately use min-height without affecting the spinner.
because the spinner now exists separately to it (as mx_RoomView_messagePanelSpinner) so their CSS is disentangled.
|
if this works, lgtm |
|
lgtm |
|
The tests could not have changed status WRT to this PR. Seems changing the react-beautiful-dnd DragDropContext has introduced weirdness, possibly because we're testing by assuming there might be a branch on matrix-react-sdk with the same name as this, but unfortunately this branch might not have had develop merged into it. Yet another reason to have one project. |
when clicking on permalinks/jump to first
Fixes #4121, #5544, #6105
See matrix-org/matrix-react-sdk#1747