Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add demo for shipping Vector internal logs/metrics to Datadog #7

Merged
merged 5 commits into from
Sep 2, 2021
Merged

Add demo for shipping Vector internal logs/metrics to Datadog #7

merged 5 commits into from
Sep 2, 2021

Conversation

lucperkins
Copy link
Contributor

@lucperkins lucperkins commented Sep 2, 2021 •
edited
Loading

No description provided.

Luc Perkins added 4 commits September 1, 2021 19:03
Output Vector internal logs and metrics to DD backend
9d9f326 
Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
Set Vector logging to debug
b5ff49b 
Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
Add basic README plus tagging
2a59613 
Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
Update tag
38be321 
Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
jdrouet
jdrouet reviewed Sep 2, 2021
View reviewed changes
Copy link
Contributor

@jdrouet jdrouet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we could merge the datadog examples into a single one to avoid people to be confused.
Or remove the datadog sink from the datadog-agent example 🤔

datadog-observability/README.md Outdated Show resolved Hide resolved
@spencergilbert
Copy link
Contributor

I'm wondering if we could merge the datadog examples into a single one to avoid people to be confused.
Or remove the datadog sink from the datadog-agent example 🤔

I think datadog-agent => vector => datadog.com makes sense as an example, the sinks overlapping is only a little puzzling

Remove --remove-orphans flag from README command
3db1714 
Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
spencergilbert
spencergilbert approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@spencergilbert spencergilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should determine some more guidelines (generally) of what should be added to the demos repo, if only to control sprawl and keep demos useful

@lucperkins
Copy link
Contributor Author

I'm going to merge this as-is for now, as I can't get the datadog-agent demo to work with the Datadog API (not sure why, but noted in #8). We can merge the scenarios later if that seems like the right thing to do.

@lucperkins lucperkins merged commit e47e72f into main Sep 2, 2021
@lucperkins lucperkins deleted the vector-to-datadog branch September 2, 2021 22:23
anubhavg-icpl pushed a commit to anubhavg-icpl/vector-demos that referenced this pull request Sep 22, 2024
@lucperkins
Merge pull request vectordotdev#7 from timberio/vector-to-datadog
64ff2d6 
Add demo for shipping Vector internal logs/metrics to Datadog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrouet jdrouet jdrouet left review comments

@spencergilbert spencergilbert spencergilbert approved these changes

@jszwedko jszwedko Awaiting requested review from jszwedko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucperkins @spencergilbert @jdrouet