Skip to content

Commit

Permalink
chore(topology): Fix flaky topology_disk_buffer_conflict test (#15297)
Browse files Browse the repository at this point in the history
When the scrape interval on the `internal_metrics` source is left at the default
of 1.0 seconds or less, some kind of race condition in the
`topology_disk_buffer_conflict` test is triggered, but it is unclear why. All
these tests should work regardless of the scrape interval. This warrants further
investigation, but this at least shuts up the flaky test.
  • Loading branch information
bruceg authored Nov 18, 2022
1 parent 04aaf1a commit 408b59e
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion src/topology/test/reload.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,14 @@ use crate::{
};

fn internal_metrics_source() -> InternalMetricsConfig {
InternalMetricsConfig::default()
InternalMetricsConfig {
// TODO: A scrape interval left at the default of 1.0 seconds or less triggers some kind of
// race condition in the `topology_disk_buffer_conflict` test below, but it is unclear
// why. All these tests should work regardless of the scrape interval. This warrants further
// investigation.
scrape_interval_secs: 1.1,
..Default::default()
}
}

fn prom_remote_write_source(addr: SocketAddr) -> PrometheusRemoteWriteConfig {
Expand Down

0 comments on commit 408b59e

Please sign in to comment.