Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(vector sink): Add DataLoss error code as non-retryable (#17904)
Fixes #17895 as discussed in #17873. The Vector source propagates downstream non-retryable errors as either DataLoss or Internal GRPC error codes. However, these error codes are not treated as non-retryable by the corresponding upstream Vector sink, leading to a delivery retry loop. (update): Only treating DataLoss as non-retryable. As explained by @dsmith3197 in a commit review - Internal errors occur when At least one event in the batch had a transient error in delivery and DataLoss errors occur when At least one event in the batch had a permanent failure or rejection, with Internal taking precedence over Dataloss. With that in mind, we'll want to retry for Internal, but not DataLoss. <!-- **Your PR title must conform to the conventional commit spec!** <type>(<scope>)!: <description> * `type` = chore, enhancement, feat, fix, docs * `!` = OPTIONAL: signals a breaking change * `scope` = Optional when `type` is "chore" or "docs", available scopes https://github.com/vectordotdev/vector/blob/master/.github/semantic.yml#L20 * `description` = short description of the change Examples: * enhancement(file source): Add `sort` option to sort discovered files * feat(new source): Initial `statsd` source * fix(file source): Fix a bug discovering new files * chore(external docs): Clarify `batch_size` option --> --------- Co-authored-by: Doug Smith <dsmith3197@users.noreply.github.com>
- Loading branch information