Skip to content

Commit

Permalink
Update smp to its latest released version
Browse files Browse the repository at this point in the history
This commit updates the smp binary to its latest release, removing a legacy flow
with no user-facing change. Peer to
DataDog/datadog-agent#18725. I have not opted to update
lading in this PR as the jump from 0.12 to 0.18 is rather large.

REF SMP-673

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
  • Loading branch information
blt committed Aug 10, 2023
1 parent 8454a6f commit 88877cc
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/regression.yml
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ jobs:
export REPLICAS="10"
export TOTAL_SAMPLES="600"
export P_VALUE="0.1"
export SMP_CRATE_VERSION="0.9.1"
export SMP_CRATE_VERSION="0.10.0"
export LADING_VERSION="0.12.0"
echo "warmup seconds: ${WARMUP_SECONDS}"
Expand Down Expand Up @@ -499,7 +499,6 @@ jobs:
chmod +x ${{ runner.temp }}/bin/smp
${{ runner.temp }}/bin/smp --team-id ${{ secrets.SINGLE_MACHINE_PERFORMANCE_TEAM_ID }} job submit \
--use-curta \
--lading-version ${{ needs.compute-metadata.outputs.lading-version }} \
--total-samples ${{ needs.compute-metadata.outputs.total-samples }} \
--warmup-seconds ${{ needs.compute-metadata.outputs.warmup-seconds }} \
Expand Down Expand Up @@ -529,7 +528,6 @@ jobs:
chmod +x ${{ runner.temp }}/bin/smp
${{ runner.temp }}/bin/smp --team-id ${{ secrets.SINGLE_MACHINE_PERFORMANCE_TEAM_ID }} job status \
--use-curta \
--wait \
--wait-delay-seconds 60 \
--wait-timeout-minutes 90 \
Expand All @@ -542,7 +540,6 @@ jobs:
run: |
chmod +x ${{ runner.temp }}/bin/smp
${{ runner.temp }}/bin/smp --team-id ${{ secrets.SINGLE_MACHINE_PERFORMANCE_TEAM_ID }} job cancel \
--use-curta \
--submission-metadata ${{ runner.temp }}/submission-metadata
- name: Check status, cancelled
Expand Down Expand Up @@ -623,7 +620,6 @@ jobs:
chmod +x ${{ runner.temp }}/bin/smp
${{ runner.temp }}/bin/smp --team-id ${{ secrets.SINGLE_MACHINE_PERFORMANCE_TEAM_ID }} job result \
--use-curta \
--submission-metadata ${{ runner.temp }}/submission-metadata
- name: Check status, cancelled
Expand Down Expand Up @@ -715,7 +711,6 @@ jobs:
chmod +x ${{ runner.temp }}/bin/smp
${{ runner.temp }}/bin/smp --team-id ${{ secrets.SINGLE_MACHINE_PERFORMANCE_TEAM_ID }} job sync \
--use-curta \
--submission-metadata ${{ runner.temp }}/submission-metadata \
--output-path "${{ runner.temp }}/outputs"
Expand Down

0 comments on commit 88877cc

Please sign in to comment.