Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loki out of order handling no longer needed with recent Loki version #11131

Closed
fpytloun opened this issue Feb 1, 2022 · 3 comments
Closed

Loki out of order handling no longer needed with recent Loki version #11131

fpytloun opened this issue Feb 1, 2022 · 3 comments
Labels
type: bug A code related bug.

Comments

@fpytloun
Copy link
Contributor

fpytloun commented Feb 1, 2022 •
edited
Loading

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Vector Version

0.19.1

Vector Configuration File

...

Debug Output

Expected Behavior

Loki sink should determine Loki version that can handle out of order records and disable this filter. Eventually there could be third option of out_of_order_action which could be ignore.

Related Loki issue: grafana/loki#1544 (fixed since 2.4.0)

Actual Behavior

Vector pro-actively drops events that could be actually handled by recent Loki.

Example Data

Additional Context

References
@fpytloun fpytloun added the type: bug A code related bug. label Feb 1, 2022
fpytloun added a commit to fpytloun/vector that referenced this issue Feb 1, 2022
@fpytloun
Add ignore option to Loki sink out_of_order action
ecddfa4 
Fixes: vectordotdev#11131
@fpytloun fpytloun mentioned this issue Feb 1, 2022
Merged
@fpytloun
Copy link
Contributor Author

fpytloun commented Feb 1, 2022

Suggested fix: #11133

@jszwedko
Copy link
Member

jszwedko commented Feb 1, 2022

@fpytloun thanks for reporting and for the PR! I think this issue is a duplicate of #9223 so I'll close it in-lieu of that.

@jszwedko jszwedko closed this as completed Feb 1, 2022
@fpytloun
Copy link
Contributor Author

fpytloun commented Feb 1, 2022

@jszwedko indeed, thank you for noticing. What about my simple fix, will that work?

fpytloun added a commit to fpytloun/vector that referenced this issue Feb 2, 2022
@fpytloun
Add ignore option to Loki sink out_of_order action
5733a53 
Fixes: vectordotdev#11131
fpytloun added a commit to fpytloun/vector that referenced this issue Feb 2, 2022
@fpytloun
fix(loki sink): Add accept option to Loki sink out_of_order action
550f226 
Fixes: vectordotdev#11131
@jszwedko jszwedko mentioned this issue Feb 28, 2022
Closed
fpytloun added a commit to fpytloun/vector that referenced this issue Mar 8, 2022
@fpytloun
fix(loki sink): Add accept option to Loki sink out_of_order action
53c208d 
Fixes: vectordotdev#11131
jszwedko added a commit that referenced this issue Mar 9, 2022
@fpytloun @jszwedko
fix(loki sink): Add accept option to out_of_order_action (#11133)
d80d05d 
* fix(loki sink): Add accept option to Loki sink out_of_order action

Fixes: #11131

* fix(loki sink): Don't limit concurrency if out of order events are accepted

* Fix integration tests

I removed the tests/data/loki-config.yaml config file because the newer
version of Loki wasn't starting with it. Instead I just used the default
one, but override the setting we needed (auth.enabled).

Signed-off-by: Jesse Szwedko <jesse@szwedko.me>

* Back out concurrency adjustments

Signed-off-by: Jesse Szwedko <jesse@szwedko.me>

Co-authored-by: Jesse Szwedko <jesse@szwedko.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A code related bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jszwedko @fpytloun