Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the need for Noop transform #11786

Closed
Tracked by #11784
blt opened this issue Mar 10, 2022 · 0 comments · Fixed by #12524
Closed
Tracked by #11784

Remove the need for Noop transform #11786

blt opened this issue Mar 10, 2022 · 0 comments · Fixed by #12524
Labels
transform: pipelines Anything `pipelines` transform related

Comments

@blt
Copy link
Contributor

blt commented Mar 10, 2022 •
edited
Loading

Our non-pipeline topology does not require a Noop. It's not clear, especially if #11785 successful, that we must have a Noop for the pipelines either. As it is, the Noop is not a free construct and shows up as a cost center relative to an "unrolled" pipeline, see this comment.
@blt blt mentioned this issue Mar 10, 2022
Closed
3 tasks
@blt blt added the transform: pipelines Anything `pipelines` transform related label Mar 10, 2022
blt added a commit that referenced this issue May 2, 2022
@blt
Remove src/transforms/noop.rs
b2acec2 
It does not appear that this transform was actually in use any longer.

Resolves #11786

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
@blt blt mentioned this issue May 2, 2022
Merged
@blt blt closed this as completed in #12524 May 2, 2022
blt added a commit that referenced this issue May 2, 2022
@blt
Remove src/transforms/noop.rs (#12524)
b680e38 
It does not appear that this transform was actually in use any longer.

Resolves #11786

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
transform: pipelines Anything `pipelines` transform related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Remove src/transforms/noop.rs vectordotdev/vector
1 participant
@blt