Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a Pipeline transform that implements FunctionTransform #11787

Closed
Tracked by #11784
blt opened this issue Mar 10, 2022 · 0 comments · Fixed by #12602
Closed
Tracked by #11784

Have a Pipeline transform that implements FunctionTransform #11787

blt opened this issue Mar 10, 2022 · 0 comments · Fixed by #12602
Labels
transform: pipelines Anything `pipelines` transform related

Comments

@blt
Copy link
Contributor

blt commented Mar 10, 2022

Today PipelinesConfig does not map to a Transform instance. It is, instead, expanded into many transforms. This imposes immediate costs in terms of metrics / logs routing but more fundamentally means that the pipeline runs as a singleton. If we were able to contrive a Pipeline that implemented FunctionTransform our topology optimizations that allow for multiple FunctionTransform instances to run in parallel would kick in and improve CPU saturation.

@blt blt added the transform: pipelines Anything `pipelines` transform related label Mar 10, 2022
blt added a commit that referenced this issue May 11, 2022
This commit adjusts pipeline expansion so that they are combined, rather than,
well, expanded. This means that the sub-transforms of a pipeline run in serial
but that each pipeline as a whole can run multiple copies of itself at
once. This also cleans up many low-priority tasks.

Resolves #11787
Resolves #11784
REF #10144

Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
blt added a commit that referenced this issue May 13, 2022
This commit adjusts pipeline expansion so that they are combined, rather than,
well, expanded. This means that the sub-transforms of a pipeline run in serial
but that each pipeline as a whole can run multiple copies of itself at
once. This also cleans up many low-priority tasks.

Resolves #11787
Resolves #11784
REF #10144

Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
blt added a commit that referenced this issue May 16, 2022
* Combine pipeline stages

This commit adjusts pipeline expansion so that they are combined, rather than,
well, expanded. This means that the sub-transforms of a pipeline run in serial
but that each pipeline as a whole can run multiple copies of itself at
once. This also cleans up many low-priority tasks.

Resolves #11787
Resolves #11784
REF #10144

Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
Signed-off-by: Brian L. Troutwine <brian@troutwine.us>

* Tidy up errors, fix bug in vector.toml pipeline config

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>

* test dings

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>

* temporariliy disable http_datadog_filter_blackhole

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>

* PR feedback

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>

* PR feedback with regard to outputs

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>

* PR feedback

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>

* try 64 wide interior buffer

Signed-off-by: Brian L. Troutwine <brian@troutwine.us>

Co-authored-by: Brian L. Troutwine <brian@troutwine.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transform: pipelines Anything `pipelines` transform related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant