Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(sinks): ARC metrics are not registered with the component tags #17763

Closed
tobz opened this issue Jun 26, 2023 · 0 comments · Fixed by #17765
Closed

bug(sinks): ARC metrics are not registered with the component tags #17763

tobz opened this issue Jun 26, 2023 · 0 comments · Fixed by #17765
Labels
domain: ARC Anything related to adaptive request concurrency domain: observability Anything related to monitoring/observing Vector domain: sinks Anything related to the Vector's sinks type: bug A code related bug.

Comments

@tobz
Copy link
Contributor

tobz commented Jun 26, 2023

Currently, ARC metrics are not registered with the necessary component tags.

This occurs due to the fact that when ARC metrics are registered -- generally within the SinkConfig::build call -- the topology builder has not yet created a sink-specific tracing span, and is not executing the build call within it. This is necessary for the metrics to be registered with those component fields present so that they can be attached to the metrics.
@tobz tobz added domain: observability Anything related to monitoring/observing Vector domain: sinks Anything related to the Vector's sinks domain: ARC Anything related to adaptive request concurrency labels Jun 26, 2023
@jszwedko jszwedko added the type: bug A code related bug. label Jun 26, 2023
jszwedko added a commit that referenced this issue Jun 26, 2023
@jszwedko
fix(sinks): Add missing component span for sink building
6a2406d 
We have one for sources and transforms, but evidentially didn't for sinks.

Closes: #17763

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@jszwedko jszwedko mentioned this issue Jun 26, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 26, 2023
@jszwedko
fix(sinks): Add missing component span for sink building (#17765)
219883e 
We have one for sources and transforms, but evidentially didn't for
sinks.

Closes: #17763

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

---------

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain: ARC Anything related to adaptive request concurrency domain: observability Anything related to monitoring/observing Vector domain: sinks Anything related to the Vector's sinks type: bug A code related bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sinks): Add missing component span for sink building vectordotdev/vector
2 participants
@tobz @jszwedko