Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add acknowledgement support to common metric sinks #7657

Closed
5 tasks
Tracked by #9857
bruceg opened this issue May 28, 2021 · 1 comment
Closed
5 tasks
Tracked by #9857

Add acknowledgement support to common metric sinks #7657

bruceg opened this issue May 28, 2021 · 1 comment
Labels
sink: aws_cloudwatch_metrics Anything `aws_cloudwatch_metrics` sink related sink: influxdb_metrics Anything `influxdb_metrics` sink related sink: prometheus_remote_write Anything `prometheus_remote_write` sink related sink: sematext_metrics Anything `sematext_metrics` sink related type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@bruceg
Copy link
Member

bruceg commented May 28, 2021 •
edited
Loading

Many of the metrics sinks follow similar patterns and should have a similar pattern for adding support for acknowledgements once #6045 and #7637 are completed.

  • aws_cloudwatch_metrics
  • gcp_stackdriver_metrics
  • influxdb_metrics
  • prometheus_remote_write
  • sematext_metrics

Ref #7337
@bruceg bruceg added type: enhancement A value-adding code change that enhances its existing functionality. sink: aws_cloudwatch_metrics Anything `aws_cloudwatch_metrics` sink related sink: influxdb_metrics Anything `influxdb_metrics` sink related sink: sematext_metrics Anything `sematext_metrics` sink related sink: prometheus_remote_write Anything `prometheus_remote_write` sink related labels May 28, 2021
@bruceg bruceg mentioned this issue May 28, 2021
Open
@bruceg bruceg mentioned this issue Nov 2, 2021
Closed
34 tasks
@bruceg
Copy link
Member Author

bruceg commented Nov 5, 2021

Closing this as it is being superseded by the stream-style sink rewrites.

@bruceg bruceg closed this as completed Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sink: aws_cloudwatch_metrics Anything `aws_cloudwatch_metrics` sink related sink: influxdb_metrics Anything `influxdb_metrics` sink related sink: prometheus_remote_write Anything `prometheus_remote_write` sink related sink: sematext_metrics Anything `sematext_metrics` sink related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bruceg