chore: Avoid the use of SinkExt in src/topology/builder.rs #11188
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm starting to experiment with the removal of `Sink` implementation for `Fanout` for #10144. My in-flight work is starting to sprawl uncomfortably so this is a small patch to remove reliance on one of the related `Sink` traits. Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
|
✔️ Deploy Preview for vector-project ready! 🔨 Explore the source changes: f5d1d24 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/61fc8ea9aa7b64000884d537 😎 Browse the preview: https://deploy-preview-11188--vector-project.netlify.app |
github-actions
bot
added
the
domain: topology
Soak Test ResultsBaseline: f1400d9 ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes with confidence ≥ 90.00%: Fine details of change detection per experiment.
Fine details of each soak run.
|
tobz
approved these changes
Feb 4, 2022
What remains is implemented on |
jszwedko
pushed a commit
that referenced
this pull request
Feb 5, 2022
I'm starting to experiment with the removal of `Sink` implementation for `Fanout` for #10144. My in-flight work is starting to sprawl uncomfortably so this is a small patch to remove reliance on one of the related `Sink` traits. Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm starting to experiment with the removal of
Sinkimplementation forFanoutfor #10144. My in-flight work is starting to sprawl uncomfortably sothis is a small patch to remove reliance on one of the related
Sinktraits.Signed-off-by: Brian L. Troutwine brian@troutwine.us