fix(buffers): make LimitedSender/LimitedReceiver wake up correctly #11741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Toby Lawrence <toby@nuclearfurnace.com>
|
✔️ Deploy Preview for vector-project ready! 🔨 Explore the source changes: 792bb13 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/62281e89bf1f89000840cac7 😎 Browse the preview: https://deploy-preview-11741--vector-project.netlify.app |
Soak Test ResultsBaseline: d06ee2a ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±5%: Fine details of change detection per experiment.
Fine details of each soak run.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #11633, the introduction of
LimitedSender/LimitedReceivercoincided with some soak tests become flaky, due to Vector itself actually locking up.After further investigation, it turns out that the wakeup mechanism used for the writer-to-reader wakeups was not implemented correctly. Using
AtomicWaker, I incorrectly read the internal code and believed that a wake-up would be stored even if a waker was not yet registered... which was an incorrect understanding.This PR switches over to using
PollNotifyfor both the writer and reader wakeups instead, as it's based on the robustNotifytype fromtokio::syncwhich is high-quality and correctly tested underloom.Practically speaking, it appears to fix the issue of Vector locking up when rerunning the reproduction steps listed out in the aforementioned issue.
Fixes #11633.