fix(new_relic sink): Multiple fixes related to metrics #14528

asllop · 2022-09-23T10:38:13Z

Description

Convert tags into attributes that are sent along with Metrics.
Add metric types, two supported: gauge and count.
Improve MetricsApiModel constructor.

Issues

The following open issues are concerned with this PR:

netlify · 2022-09-23T10:38:34Z

✅ Deploy Preview for vector-project ready!

Name	Link
🔨 Latest commit	`41b41ab`
🔍 Latest deploy log	https://app.netlify.com/sites/vector-project/deploys/6397496941afc70009ff37fa
😎 Deploy Preview	https://deploy-preview-14528--vector-project.netlify.app/reports/lighthouse
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions · 2022-09-23T14:00:03Z

Soak Test Results

Baseline: a53cfef
Comparison: c3b4784
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.

experiment	Δ mean	Δ mean %	confidence	baseline mean	baseline stdev	baseline stderr	baseline CoV	comparison mean	comparison stdev	comparison stderr	comparison CoV	erratic	declared erratic
datadog_agent_remap_blackhole_acks	1.85MiB	3.06	100.00%	60.43MiB	5.49MiB	114.42KiB	0.0909064	62.28MiB	2.69MiB	56.36KiB	0.0432308	False	False
splunk_hec_route_s3	301.08KiB	1.63	100.00%	18.07MiB	2.41MiB	50.27KiB	0.133497	18.37MiB	2.36MiB	49.35KiB	0.128597	False	False
http_to_http_acks	242.48KiB	1.39	71.49%	17.03MiB	7.64MiB	159.73KiB	0.448495	17.27MiB	7.71MiB	161.04KiB	0.446526	True	True
syslog_regex_logs2metric_ddmetrics	163.08KiB	1.3	100.00%	12.25MiB	514.77KiB	10.49KiB	0.0410222	12.41MiB	626.14KiB	12.75KiB	0.0492576	False	False
syslog_log2metric_humio_metrics	137.97KiB	1.08	100.00%	12.42MiB	379.44KiB	7.74KiB	0.0298234	12.56MiB	550.47KiB	11.21KiB	0.0428024	False	False
http_pipelines_blackhole_acks	6.78KiB	0.55	98.07%	1.19MiB	105.27KiB	2.14KiB	0.0860447	1.2MiB	95.64KiB	1.95KiB	0.0777409	False	False
splunk_hec_to_splunk_hec_logs_noack	4.39KiB	0.02	33.25%	23.83MiB	374.29KiB	7.64KiB	0.0153337	23.84MiB	331.96KiB	6.78KiB	0.0135974	False	False
enterprise_http_to_http	954.86B	0	10.15%	23.85MiB	253.02KiB	5.16KiB	0.0103599	23.85MiB	252.78KiB	5.17KiB	0.0103499	False	False
splunk_hec_indexer_ack_blackhole	-3.55KiB	-0.01	11.44%	23.75MiB	835.57KiB	17.0KiB	0.0343458	23.75MiB	881.56KiB	17.93KiB	0.0362416	False	False
splunk_hec_to_splunk_hec_logs_acks	-5.11KiB	-0.02	16.39%	23.76MiB	826.04KiB	16.81KiB	0.0339472	23.75MiB	889.28KiB	18.09KiB	0.036554	False	False
http_pipelines_blackhole	-717.79B	-0.04	26.14%	1.7MiB	20.35KiB	425.97B	0.0116646	1.7MiB	100.98KiB	2.06KiB	0.0578922	False	False
file_to_blackhole	-125.58KiB	-0.13	77.93%	95.35MiB	2.87MiB	59.41KiB	0.0300509	95.23MiB	4.02MiB	83.57KiB	0.0422483	False	False
http_to_http_json	-52.99KiB	-0.22	99.98%	23.85MiB	335.79KiB	6.85KiB	0.013748	23.8MiB	599.21KiB	12.22KiB	0.0245865	False	False
fluent_elasticsearch	-229.43KiB	-0.28	99.99%	79.47MiB	52.58KiB	1.06KiB	0.000646017	79.25MiB	2.82MiB	58.03KiB	0.035635	False	False
datadog_agent_remap_blackhole	-227.66KiB	-0.36	97.60%	61.19MiB	4.06MiB	84.61KiB	0.0663418	60.97MiB	2.63MiB	54.81KiB	0.0430626	False	False
syslog_splunk_hec_logs	-78.82KiB	-0.48	100.00%	16.13MiB	750.42KiB	15.27KiB	0.0454256	16.05MiB	497.42KiB	10.16KiB	0.0302549	False	False
http_to_http_noack	-121.57KiB	-0.5	100.00%	23.84MiB	407.47KiB	8.34KiB	0.0166902	23.72MiB	1.23MiB	25.67KiB	0.0519231	False	False
syslog_humio_logs	-121.95KiB	-0.72	100.00%	16.44MiB	598.69KiB	12.22KiB	0.0355479	16.32MiB	606.67KiB	12.42KiB	0.0362849	False	False
datadog_agent_remap_datadog_logs	-600.5KiB	-0.95	100.00%	61.49MiB	544.18KiB	11.14KiB	0.00864012	60.91MiB	3.77MiB	78.49KiB	0.0618276	False	False
datadog_agent_remap_datadog_logs_acks	-745.96KiB	-1.19	100.00%	61.43MiB	2.78MiB	58.14KiB	0.04523	60.7MiB	4.35MiB	90.51KiB	0.0716164	False	False
http_pipelines_no_grok_blackhole	-159.79KiB	-1.48	100.00%	10.55MiB	210.88KiB	4.31KiB	0.0195129	10.4MiB	1015.01KiB	20.65KiB	0.0953298	False	False
socket_to_socket_blackhole	-364.39KiB	-1.55	100.00%	22.91MiB	647.09KiB	13.21KiB	0.0275732	22.56MiB	599.57KiB	12.24KiB	0.0259509	False	False
syslog_log2metric_splunk_hec_metrics	-367.64KiB	-2.21	100.00%	16.26MiB	1.65MiB	34.42KiB	0.101318	15.91MiB	1.76MiB	36.59KiB	0.110367	False	False
syslog_loki	-353.49KiB	-2.3	100.00%	14.99MiB	386.55KiB	7.91KiB	0.0251812	14.64MiB	740.5KiB	15.05KiB	0.0493764	False	False
http_text_to_http_json	-1.04MiB	-2.67	100.00%	38.81MiB	825.63KiB	16.85KiB	0.0207721	37.77MiB	836.07KiB	17.07KiB	0.0216115	False	False

src/sinks/new_relic/config.rs

bruceg

This looks pretty good, but it appears there is no test coverage for this data. It looks like tests.rs is testing part of what you're changing here, could you update the tests to cover everything?

src/sinks/new_relic/model.rs

bruceg · 2022-10-21T16:21:19Z

Oh, it also looks like this needs to be merged with the current master branch to pull in fixes to the protoc setup on CI tests.

Co-authored-by: Bruce Guenter <bruce@untroubled.org>

netlify · 2022-11-03T11:43:43Z

❌ Deploy Preview for vrl-playground failed.

Name	Link
🔨 Latest commit	`41b41ab`
🔍 Latest deploy log	https://app.netlify.com/sites/vrl-playground/deploys/639749695eaf5100070c063b

Co-authored-by: Bruce Guenter <bruce@untroubled.org>

asllop · 2022-11-04T12:44:44Z

@bruceg all the requested changes are made, ready for review.

github-actions · 2022-11-04T14:22:12Z

Soak Test Results

Baseline: cf73729
Comparison: 84a8d61
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.

experiment	Δ mean	Δ mean %	confidence	baseline mean	baseline stdev	baseline stderr	baseline CoV	comparison mean	comparison stdev	comparison stderr	comparison CoV	erratic	declared erratic
syslog_log2metric_splunk_hec_metrics	369.7KiB	2.23	100.00%	16.19MiB	576.23KiB	11.74KiB	0.0347422	16.55MiB	597.15KiB	12.17KiB	0.0352186	False	False
syslog_loki	312.81KiB	1.98	100.00%	15.4MiB	542.24KiB	11.1KiB	0.0343877	15.7MiB	780.04KiB	15.86KiB	0.0485065	False	False
syslog_humio_logs	302.54KiB	1.85	100.00%	16.01MiB	142.3KiB	2.91KiB	0.00867976	16.3MiB	154.74KiB	3.17KiB	0.00926706	False	False
syslog_regex_logs2metric_ddmetrics	131.56KiB	1.64	100.00%	7.83MiB	829.81KiB	16.89KiB	0.103538	7.95MiB	757.99KiB	15.44KiB	0.0930493	False	False
syslog_splunk_hec_logs	262.67KiB	1.62	100.00%	15.81MiB	700.51KiB	14.26KiB	0.0432737	16.06MiB	622.58KiB	12.69KiB	0.0378454	False	False
splunk_hec_route_s3	258.41KiB	1.18	100.00%	21.41MiB	2.25MiB	46.82KiB	0.10503	21.66MiB	1.94MiB	40.55KiB	0.0895082	False	False
http_to_http_acks	162.51KiB	0.92	49.52%	17.25MiB	8.39MiB	175.37KiB	0.486189	17.41MiB	8.1MiB	169.11KiB	0.465162	True	True
http_pipelines_blackhole_acks	7.3KiB	0.58	99.40%	1.22MiB	114.44KiB	2.33KiB	0.0916395	1.23MiB	62.63KiB	1.28KiB	0.0498627	False	False
syslog_log2metric_humio_metrics	35.14KiB	0.35	99.97%	9.77MiB	197.93KiB	4.04KiB	0.0197795	9.8MiB	434.78KiB	8.85KiB	0.0432964	False	False
splunk_hec_to_splunk_hec_logs_noack	26.48KiB	0.11	95.98%	23.81MiB	536.95KiB	10.95KiB	0.0220165	23.84MiB	333.84KiB	6.82KiB	0.0136737	False	False
enterprise_http_to_http	1.06KiB	0	11.36%	23.85MiB	258.87KiB	5.28KiB	0.0105997	23.85MiB	253.39KiB	5.18KiB	0.0103748	False	False
splunk_hec_to_splunk_hec_logs_acks	-6.42KiB	-0.03	20.16%	23.75MiB	857.57KiB	17.44KiB	0.0352518	23.75MiB	889.52KiB	18.09KiB	0.0365746	False	False
splunk_hec_indexer_ack_blackhole	-14.01KiB	-0.06	40.72%	23.76MiB	881.79KiB	17.94KiB	0.0362374	23.74MiB	938.11KiB	19.08KiB	0.0385744	False	False
file_to_blackhole	-76.89KiB	-0.08	51.24%	95.34MiB	3.57MiB	73.97KiB	0.0374222	95.26MiB	3.97MiB	82.43KiB	0.0416299	False	False
datadog_agent_remap_blackhole_acks	-45.37KiB	-0.08	32.97%	58.26MiB	3.92MiB	81.73KiB	0.067329	58.21MiB	3.27MiB	68.38KiB	0.0562352	False	False
http_to_http_json	-42.13KiB	-0.17	99.69%	23.84MiB	389.32KiB	7.95KiB	0.0159414	23.8MiB	580.12KiB	11.84KiB	0.0237954	False	False
datadog_agent_remap_blackhole	-115.25KiB	-0.2	74.18%	57.67MiB	3.91MiB	81.53KiB	0.0678616	57.55MiB	2.93MiB	61.17KiB	0.0509415	False	False
fluent_elasticsearch	-186.9KiB	-0.23	100.00%	79.47MiB	53.78KiB	1.09KiB	0.000660695	79.29MiB	1.65MiB	33.92KiB	0.0207806	False	False
http_to_http_noack	-61.33KiB	-0.25	99.67%	23.84MiB	411.3KiB	8.41KiB	0.0168467	23.78MiB	935.07KiB	19.06KiB	0.0383963	False	False
http_pipelines_blackhole	-9.67KiB	-0.55	100.00%	1.7MiB	10.95KiB	229.04B	0.00627089	1.69MiB	83.41KiB	1.7KiB	0.0480535	False	False
http_pipelines_no_grok_blackhole	-85.24KiB	-0.8	99.99%	10.42MiB	210.31KiB	4.3KiB	0.0197121	10.33MiB	1015.34KiB	20.65KiB	0.0959323	False	False
http_text_to_http_json	-420.29KiB	-1.05	100.00%	39.03MiB	816.9KiB	16.67KiB	0.020436	38.62MiB	1.01MiB	21.04KiB	0.0260534	False	False
datadog_agent_remap_datadog_logs_acks	-746.11KiB	-1.33	100.00%	54.86MiB	2.47MiB	51.69KiB	0.0450354	54.13MiB	3.83MiB	79.63KiB	0.0706607	False	False
socket_to_socket_blackhole	-356.79KiB	-1.48	100.00%	23.57MiB	133.05KiB	2.72KiB	0.00551064	23.22MiB	136.67KiB	2.79KiB	0.00574557	False	False
datadog_agent_remap_datadog_logs	-923.92KiB	-1.64	100.00%	55.09MiB	571.01KiB	11.69KiB	0.0101191	54.19MiB	3.77MiB	78.41KiB	0.0694783	False	False

bruceg

It looks like this just needs a cargo fmt and it's ready to go.

github-actions · 2022-12-12T16:25:45Z

Regression Test Results

Run ID: 5622bb06-7768-49df-a22f-c3fd10f45c94
Baseline: 0bd85bb
Comparison: 41b41ab
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their bytes_written_per_cpu_second performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean bytes_written_per_cpu_second are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting changes are observed.

Changes in bytes_written_per_cpu_second with confidence ≥ 90.00% and absolute Δ mean >= ±5%:

experiment	Δ mean	Δ mean %	confidence
syslog_regex_logs2metric_ddmetrics	261.65KiB/CPU-s	6.8	100.00%
syslog_loki	520.14KiB/CPU-s	6.25	100.00%
http_pipelines_no_grok_blackhole	-504.69KiB/CPU-s	-7.54	100.00%
splunk_hec_route_s3	-952.63KiB/CPU-s	-7.81	100.00%
syslog_log2metric_humio_metrics	-494.0KiB/CPU-s	-8.0	100.00%
datadog_agent_remap_datadog_logs_acks	-3.95MiB/CPU-s	-11.68	100.00%
datadog_agent_remap_datadog_logs	-4.02MiB/CPU-s	-11.73	100.00%

Fine details of change detection per experiment.

experiment	Δ mean	Δ mean %	confidence	baseline mean	baseline stdev	baseline stderr	baseline CoV	comparison mean	comparison stdev	comparison stderr	comparison CoV	erratic	declared erratic
syslog_regex_logs2metric_ddmetrics	261.65KiB/CPU-s	6.8	100.00%	3.76MiB/CPU-s	436.53KiB/CPU-s	5.64KiB/CPU-s	0.113472	4.01MiB/CPU-s	553.08KiB/CPU-s	7.14KiB/CPU-s	0.134611	True	False
syslog_loki	520.14KiB/CPU-s	6.25	100.00%	8.13MiB/CPU-s	493.84KiB/CPU-s	6.38KiB/CPU-s	0.059307	8.64MiB/CPU-s	397.6KiB/CPU-s	5.13KiB/CPU-s	0.044942	False	False
socket_to_socket_blackhole	637.69KiB/CPU-s	4.92	100.00%	12.66MiB/CPU-s	238.76KiB/CPU-s	3.08KiB/CPU-s	0.018414	13.28MiB/CPU-s	141.89KiB/CPU-s	1.83KiB/CPU-s	0.01043	False	False
syslog_humio_logs	344.25KiB/CPU-s	3.75	100.00%	8.96MiB/CPU-s	154.53KiB/CPU-s	1.99KiB/CPU-s	0.016841	9.3MiB/CPU-s	135.32KiB/CPU-s	1.75KiB/CPU-s	0.014215	False	False
syslog_splunk_hec_logs	310.12KiB/CPU-s	3.42	100.00%	8.86MiB/CPU-s	186.32KiB/CPU-s	2.41KiB/CPU-s	0.020532	9.16MiB/CPU-s	193.22KiB/CPU-s	2.49KiB/CPU-s	0.020588	False	False
syslog_log2metric_splunk_hec_metrics	53.0KiB/CPU-s	0.56	100.00%	9.32MiB/CPU-s	138.71KiB/CPU-s	1.79KiB/CPU-s	0.014533	9.37MiB/CPU-s	111.29KiB/CPU-s	1.44KiB/CPU-s	0.011597	False	False
http_to_http_acks	6.0KiB/CPU-s	0.11	8.99%	5.3MiB/CPU-s	2.83MiB/CPU-s	37.41KiB/CPU-s	0.534442	5.3MiB/CPU-s	2.86MiB/CPU-s	37.83KiB/CPU-s	0.539935	True	False
enterprise_http_to_http	12.7KiB/CPU-s	0.09	99.30%	13.61MiB/CPU-s	332.23KiB/CPU-s	4.29KiB/CPU-s	0.023833	13.62MiB/CPU-s	150.54KiB/CPU-s	1.94KiB/CPU-s	0.010789	False	False
http_to_http_noack	8.4KiB/CPU-s	0.06	86.37%	13.61MiB/CPU-s	352.72KiB/CPU-s	4.55KiB/CPU-s	0.025307	13.62MiB/CPU-s	257.71KiB/CPU-s	3.33KiB/CPU-s	0.018479	False	False
splunk_hec_to_splunk_hec_logs_noack	5.34KiB/CPU-s	0.04	82.71%	13.62MiB/CPU-s	235.16KiB/CPU-s	3.03KiB/CPU-s	0.01686	13.62MiB/CPU-s	191.65KiB/CPU-s	2.47KiB/CPU-s	0.013735	False	False
splunk_hec_indexer_ack_blackhole	3.03KiB/CPU-s	0.02	50.08%	13.62MiB/CPU-s	254.84KiB/CPU-s	3.29KiB/CPU-s	0.018276	13.62MiB/CPU-s	236.72KiB/CPU-s	3.05KiB/CPU-s	0.016973	False	False
http_to_http_json	-150.88B/CPU-s	-0.0	3.01%	13.62MiB/CPU-s	211.24KiB/CPU-s	2.73KiB/CPU-s	0.015143	13.62MiB/CPU-s	216.88KiB/CPU-s	2.8KiB/CPU-s	0.015548	False	False
fluent_elasticsearch	-79.02B/CPU-s	-0.0	11.41%	45.41MiB/CPU-s	29.96KiB/CPU-s	391.81B/CPU-s	0.000644	45.41MiB/CPU-s	29.58KiB/CPU-s	386.73B/CPU-s	0.000636	False	False
file_to_blackhole	-13.06KiB/CPU-s	-0.02	44.98%	54.49MiB/CPU-s	1.09MiB/CPU-s	14.44KiB/CPU-s	0.020054	54.48MiB/CPU-s	1.24MiB/CPU-s	16.41KiB/CPU-s	0.022829	False	False
otlp_grpc_to_blackhole	-174.95B/CPU-s	-0.02	19.15%	963.37KiB/CPU-s	31.15KiB/CPU-s	411.88B/CPU-s	0.032336	963.2KiB/CPU-s	44.87KiB/CPU-s	592.9B/CPU-s	0.046579	False	False
splunk_hec_to_splunk_hec_logs_acks	-2.59KiB/CPU-s	-0.02	30.79%	13.62MiB/CPU-s	343.14KiB/CPU-s	4.43KiB/CPU-s	0.024606	13.61MiB/CPU-s	372.61KiB/CPU-s	4.81KiB/CPU-s	0.026724	False	False
otlp_http_to_blackhole	-4.89KiB/CPU-s	-0.34	93.63%	1.4MiB/CPU-s	141.4KiB/CPU-s	1.82KiB/CPU-s	0.098393	1.4MiB/CPU-s	147.58KiB/CPU-s	1.9KiB/CPU-s	0.103046	True	False
datadog_agent_remap_blackhole_acks	-475.04KiB/CPU-s	-1.5	100.00%	30.86MiB/CPU-s	840.66KiB/CPU-s	10.86KiB/CPU-s	0.026601	30.4MiB/CPU-s	968.93KiB/CPU-s	12.51KiB/CPU-s	0.031128	False	False
http_pipelines_blackhole_acks	-41.81KiB/CPU-s	-2.19	100.00%	1.86MiB/CPU-s	76.09KiB/CPU-s	1005.93B/CPU-s	0.039916	1.82MiB/CPU-s	30.12KiB/CPU-s	398.19B/CPU-s	0.016154	False	False
http_text_to_http_json	-620.45KiB/CPU-s	-2.5	100.00%	24.28MiB/CPU-s	571.49KiB/CPU-s	7.38KiB/CPU-s	0.022983	23.67MiB/CPU-s	522.07KiB/CPU-s	6.74KiB/CPU-s	0.021533	False	False
http_pipelines_blackhole	-85.28KiB/CPU-s	-3.25	100.00%	2.56MiB/CPU-s	122.27KiB/CPU-s	1.58KiB/CPU-s	0.046634	2.48MiB/CPU-s	66.06KiB/CPU-s	873.18B/CPU-s	0.026042	False	False
datadog_agent_remap_blackhole	-1.11MiB/CPU-s	-3.49	100.00%	31.79MiB/CPU-s	649.04KiB/CPU-s	8.38KiB/CPU-s	0.019935	30.68MiB/CPU-s	742.46KiB/CPU-s	9.58KiB/CPU-s	0.023629	False	False
http_pipelines_no_grok_blackhole	-504.69KiB/CPU-s	-7.54	100.00%	6.54MiB/CPU-s	82.54KiB/CPU-s	1.07KiB/CPU-s	0.01233	6.04MiB/CPU-s	135.3KiB/CPU-s	1.75KiB/CPU-s	0.021861	False	False
splunk_hec_route_s3	-952.63KiB/CPU-s	-7.81	100.00%	11.91MiB/CPU-s	521.41KiB/CPU-s	6.73KiB/CPU-s	0.042733	10.98MiB/CPU-s	535.46KiB/CPU-s	6.91KiB/CPU-s	0.047601	False	False
syslog_log2metric_humio_metrics	-494.0KiB/CPU-s	-8.0	100.00%	6.03MiB/CPU-s	87.6KiB/CPU-s	1.13KiB/CPU-s	0.014178	5.55MiB/CPU-s	158.51KiB/CPU-s	2.05KiB/CPU-s	0.027886	False	False
datadog_agent_remap_datadog_logs_acks	-3.95MiB/CPU-s	-11.68	100.00%	33.76MiB/CPU-s	1.35MiB/CPU-s	17.89KiB/CPU-s	0.040105	29.82MiB/CPU-s	840.72KiB/CPU-s	10.85KiB/CPU-s	0.027531	False	False
datadog_agent_remap_datadog_logs	-4.02MiB/CPU-s	-11.73	100.00%	34.29MiB/CPU-s	1.08MiB/CPU-s	14.22KiB/CPU-s	0.031386	30.26MiB/CPU-s	1.0MiB/CPU-s	13.25KiB/CPU-s	0.033131	False	False

davidhuie-dd · 2023-01-23T22:13:22Z

Looks like there are some newer compilation errors concerning MetricTags.

asllop · 2023-01-31T08:21:27Z

@davidhuie-dd ok, let me check, I'll have a look ASAP.

jszwedko · 2023-06-01T15:24:26Z

Hey @asllop ! Just wondering if you think you'll get a chance to circle back to this.

dsmith3197 · 2023-09-13T11:53:57Z

Done in #18151

asllop added 7 commits September 15, 2022 09:39

Convert tags into attributes.

05025b1

Merge branch 'vectordotdev:master' into master

4cdef4e

Decompose metric into parts to reuse tags instead of cloning.

087d4bf

Remove unnecessary blocks.

2dd2668

Set metric type.

6020efb

Fix field name typo.

9e7d57c

Remove unnecessary brackets.

567f236

github-actions bot added the domain: sinks Anything related to the Vector's sinks label Sep 23, 2022

Merge branch 'master' into master

c3b4784

jszwedko requested a review from StephenWakely September 23, 2022 22:19

StephenWakely requested review from bruceg and tobz October 13, 2022 11:00

bruceg reviewed Oct 14, 2022

View reviewed changes

src/sinks/new_relic/config.rs Outdated Show resolved Hide resolved

asllop added 2 commits October 20, 2022 10:04

Cargo fmt.

b755769

Merge branch 'master' of https://github.com/asllop/vector

67943c9

jszwedko requested a review from bruceg October 20, 2022 16:10

bruceg reviewed Oct 21, 2022

View reviewed changes

src/sinks/new_relic/model.rs Outdated Show resolved Hide resolved

src/sinks/new_relic/model.rs Outdated Show resolved Hide resolved

src/sinks/new_relic/model.rs Outdated Show resolved Hide resolved

Update src/sinks/new_relic/model.rs

48f16d8

Co-authored-by: Bruce Guenter <bruce@untroubled.org>

asllop and others added 5 commits November 3, 2022 12:43

Update src/sinks/new_relic/model.rs

af14a7d

Co-authored-by: Bruce Guenter <bruce@untroubled.org>

Fix typo.

137943c

Add tests for newly supported metrics.

2a2282c

Simplify metric type cases.

b72faed

Merge branch 'vectordotdev:master' into master

84a8d61

asllop removed the request for review from StephenWakely November 7, 2022 13:57

asllop requested review from bruceg and removed request for tobz November 7, 2022 13:57

jszwedko assigned bruceg Dec 2, 2022

jszwedko requested a review from davidhuie-dd December 2, 2022 20:26

bruceg previously approved these changes Dec 8, 2022

View reviewed changes

Cargo fmt.

41b41ab

jszwedko assigned davidhuie-dd Jan 23, 2023

jszwedko added the meta: awaiting author Pull requests that are awaiting their author. label Mar 29, 2023

asllop dismissed bruceg’s stale review via 41b41ab July 10, 2023 15:27

jszwedko mentioned this pull request Aug 3, 2023

fix(new_relic sink): Multiple fixes related to metrics #18151

Merged

dsmith3197 closed this Sep 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(new_relic sink): Multiple fixes related to metrics #14528

fix(new_relic sink): Multiple fixes related to metrics #14528

asllop commented Sep 23, 2022

netlify bot commented Sep 23, 2022 •

edited

Loading

github-actions bot commented Sep 23, 2022

bruceg left a comment

bruceg commented Oct 21, 2022

netlify bot commented Nov 3, 2022 •

edited

Loading

asllop commented Nov 4, 2022

github-actions bot commented Nov 4, 2022

bruceg left a comment

github-actions bot commented Dec 12, 2022

davidhuie-dd commented Jan 23, 2023

asllop commented Jan 31, 2023

jszwedko commented Jun 1, 2023

dsmith3197 commented Sep 13, 2023

fix(new_relic sink): Multiple fixes related to metrics #14528

fix(new_relic sink): Multiple fixes related to metrics #14528

Conversation

asllop commented Sep 23, 2022

Description

Issues

netlify bot commented Sep 23, 2022 • edited Loading

✅ Deploy Preview for vector-project ready!

github-actions bot commented Sep 23, 2022

Soak Test Results

bruceg left a comment

Choose a reason for hiding this comment

bruceg commented Oct 21, 2022

netlify bot commented Nov 3, 2022 • edited Loading

❌ Deploy Preview for vrl-playground failed.

asllop commented Nov 4, 2022

github-actions bot commented Nov 4, 2022

Soak Test Results

bruceg left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 12, 2022

Regression Test Results

davidhuie-dd commented Jan 23, 2023

asllop commented Jan 31, 2023

jszwedko commented Jun 1, 2023

dsmith3197 commented Sep 13, 2023

netlify bot commented Sep 23, 2022 •

edited

Loading

netlify bot commented Nov 3, 2022 •

edited

Loading