-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(vrl): Add Kind::remove
#14775
chore(vrl): Add Kind::remove
#14775
Conversation
✅ Deploy Preview for vector-project canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of pedantic suggestions 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The remove
logic is quite involved, I didn't try to understand every nuance of it. That being said, there was nothing that stood out as particularly odd to me. +1 for the extensive set of tests to cover this area.
Co-authored-by: Pablo Sichert <mail@pablosichert.com>
Co-authored-by: Pablo Sichert <mail@pablosichert.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks for doing this.
…into fuchsnj/kind_remove
closes #13460
makes progress on #7070
This replaces the
Kind::remove_at_path
with a newKind::remove
.