Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update template and field path syntax #14849

Merged
merged 5 commits into from
Oct 14, 2022

Conversation

spencergilbert
Copy link
Contributor

Field path notation has been replaced by the shared lookup code. Problematically we don't report errors from these very well see #13033 for the solution there.

Technically these don't require (today) a leading . in the path expression, but that may change in the future and, to me, it's less confusing to have two different ways of handling lookups.

@netlify
Copy link

netlify bot commented Oct 14, 2022

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit 45ee385
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/6349c0e72919120008c8ab38
😎 Deploy Preview https://deploy-preview-14849--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>
@spencergilbert spencergilbert marked this pull request as ready for review October 14, 2022 19:01
@spencergilbert spencergilbert self-assigned this Oct 14, 2022
Signed-off-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>
@spencergilbert spencergilbert requested review from a team October 14, 2022 19:03
@spencergilbert spencergilbert added the domain: external docs Anything related to Vector's external, public documentation label Oct 14, 2022
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Seems like deploy is failing, but I can review again when the deploy is up.

Signed-off-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>
@github-actions github-actions bot removed the domain: external docs Anything related to Vector's external, public documentation label Oct 14, 2022
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@neuronull neuronull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly reviewed for spelling/grammar.

…x.md

Co-authored-by: neuronull <kyle.criddle@datadoghq.com>
@spencergilbert spencergilbert merged commit 078341f into master Oct 14, 2022
@spencergilbert spencergilbert deleted the spencer/fix-template-syntax branch October 14, 2022 20:08
@jszwedko jszwedko added this to the Vector v0.25.0 milestone Oct 27, 2022
jszwedko pushed a commit that referenced this pull request Oct 27, 2022
* docs: Update template and field path syntax

* +netlify redirect path-fields to vrl/expressions/#path

Signed-off-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>

* +delete old field-path page

Signed-off-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>

* +fix link

Signed-off-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>

* Update website/content/en/docs/reference/configuration/template-syntax.md

Co-authored-by: neuronull <kyle.criddle@datadoghq.com>

Signed-off-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>
Co-authored-by: neuronull <kyle.criddle@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants