Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update Rust to 1.67.1 #16212

Closed
wants to merge 3 commits into from
Closed

Conversation

bruceg
Copy link
Member

@bruceg bruceg commented Jan 31, 2023

This is mostly clippy fixes of format!("{}", x) into format!("{x}"), with a few dozen if let … else sprinkled in, except for an issue with track_caller in the test utils.

@bruceg bruceg added the type: tech debt A code change that does not add user value. label Jan 31, 2023
@bruceg bruceg requested a review from a team January 31, 2023 14:37
@netlify
Copy link

netlify bot commented Jan 31, 2023

Deploy Preview for vrl-playground ready!

Name Link
🔨 Latest commit a0b9e60
🔍 Latest deploy log https://app.netlify.com/sites/vrl-playground/deploys/63e526783e5ad500079f3d6f
😎 Deploy Preview https://deploy-preview-16212--vrl-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 31, 2023

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit a0b9e60
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/63e52678cd4cc0000802c69b
😎 Deploy Preview https://deploy-preview-16212--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added domain: codecs Anything related to Vector's codecs (encoding/decoding) domain: core Anything related to core crates i.e. vector-core, core-common, etc domain: sinks Anything related to the Vector's sinks domain: sources Anything related to the Vector's sources domain: topology Anything related to Vector's topology code domain: transforms Anything related to Vector's transform components domain: vrl Anything related to the Vector Remap Language labels Jan 31, 2023
@bruceg bruceg added the ci-condition: integration tests enable Run integration tests on this PR label Jan 31, 2023
@tobz
Copy link
Contributor

tobz commented Jan 31, 2023

@bruceg We should hold on this temporarily.

It looks like the change to struct field grouping has the potential to cause deserialization issues with rkyv for data that was serialized with a build based on a prior version of Rust.

I'll have to look into this a little more and see if it effects us and our particular archived structs.

@bruceg bruceg marked this pull request as draft January 31, 2023 21:31
@bruceg
Copy link
Member Author

bruceg commented Jan 31, 2023

Possibly related: rust-lang/rust#107440

@tobz
Copy link
Contributor

tobz commented Feb 1, 2023

For posterity, my comment above about holding can be considered resolved.

Chatting with the author of rkyv, we should be entirely protected from the aforementioned struct field ordering change as we use the strict feature flag for rkyv, which ensures a (more) deterministic object layout, regardless of compiler version, and so on.

@bruceg bruceg changed the title chore(deps): Update Rust to 1.67.0 chore(deps): Update Rust to 1.67.1 Feb 9, 2023
@jszwedko jszwedko mentioned this pull request Mar 9, 2023
@bruceg
Copy link
Member Author

bruceg commented Mar 9, 2023

Replaced by #16744

@bruceg bruceg closed this Mar 9, 2023
@bruceg bruceg deleted the bruceg/update-rust-1-67 branch March 9, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-condition: integration tests enable Run integration tests on this PR domain: codecs Anything related to Vector's codecs (encoding/decoding) domain: core Anything related to core crates i.e. vector-core, core-common, etc domain: sinks Anything related to the Vector's sinks domain: sources Anything related to the Vector's sources domain: topology Anything related to Vector's topology code domain: transforms Anything related to Vector's transform components domain: vrl Anything related to the Vector Remap Language type: tech debt A code change that does not add user value.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants