Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal telemetry at shutdown): close internal sources after external ones #17741

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
datadog traces are not internal
  • Loading branch information
DominicBurkart authored Jun 26, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 62db883f551d2f0d3ee2439b7dda77848e9c534d
2 changes: 1 addition & 1 deletion src/topology/builder.rs
Original file line number Diff line number Diff line change
@@ -70,7 +70,7 @@ static TRANSFORM_CONCURRENCY_LIMIT: Lazy<usize> = Lazy::new(|| {
.unwrap_or_else(crate::num_threads)
});

const INTERNAL_SOURCES: [&str; 3] = ["internal_logs", "internal_metrics", "datadog_traces"];
const INTERNAL_SOURCES: [&str; 2] = ["internal_logs", "internal_metrics"];

/// Builds only the new pieces, and doesn't check their topology.
pub async fn build_pieces(