Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate hanwritten and generated files in web-playground #17871

Merged
merged 2 commits into from
Jul 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/vector-vrl/web-playground/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ cargo install --locked --version 0.10.3 wasm-pack
After installing `wasm-pack` we must compile our project by running:

```shell
wasm-pack build --target web --out-dir public
wasm-pack build --target web --out-dir public/pkg
```

Notice the `public` directory was populated with `.wasm`, and `.js`,
Expand All @@ -41,6 +41,7 @@ the web browser console.
To see this in action we host `index.html` locally, for example by running:

```shell
cd public
python3 -m http.server
```

Expand Down
2 changes: 1 addition & 1 deletion lib/vector-vrl/web-playground/netlify.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
publish = "public/"

# Default build command.
command = "bash ../../../scripts/ensure-wasm-pack-installed.sh && wasm-pack build --target web --out-dir public"
command = "bash ../../../scripts/ensure-wasm-pack-installed.sh && wasm-pack build --target web --out-dir public/pkg"

# Ignore everything except the base directory and changes to vector/lib/
ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF . ../../../lib"
1 change: 0 additions & 1 deletion lib/vector-vrl/web-playground/public/.gitignore

This file was deleted.

147 changes: 0 additions & 147 deletions lib/vector-vrl/web-playground/public/README.md

This file was deleted.

2 changes: 1 addition & 1 deletion lib/vector-vrl/web-playground/public/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import init, { run_vrl } from "./vector_vrl_web_playground.js";
import init, { run_vrl } from "./pkg/vector_vrl_web_playground.js";
import { vrlLanguageDefinition, vrlThemeDefinition } from "./vrl-highlighter.js";

const PROGRAM_EDITOR_DEFAULT_VALUE = `# Remove some fields
Expand Down