Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(observability): deprecate obsolete http metrics #18972

Merged
merged 9 commits into from
Nov 3, 2023
Merged

chore(observability): deprecate obsolete http metrics #18972

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2e7322e
OPW-94 deprecate obsolete http metrics
dsmith3197 Oct 27, 2023
a471c59
feedback
dsmith3197 Oct 30, 2023
e8c5079
feedback
dsmith3197 Oct 30, 2023
8c1213f
Merge branch 'master' into dougsmith/deprecate-old-http-metrics
dsmith3197 Oct 30, 2023
fb2f173
Merge branch 'master' into dougsmith/deprecate-old-http-metrics
dsmith3197 Oct 31, 2023
bfab421
fmt
dsmith3197 Oct 31, 2023
d63574b
Merge branch 'master' into dougsmith/deprecate-old-http-metrics
dsmith3197 Nov 1, 2023
63484d4
Update DEPRECATIONS.md
dsmith3197 Nov 1, 2023
aada1ea
Merge branch 'master' into dougsmith/deprecate-old-http-metrics
dsmith3197 Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/DEPRECATIONS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ See [DEPRECATION.md](docs/DEPRECATION.md#process) for the process for updating t

## To be removed

### 0.34.0
* Support for `v1` series endpoint in the `datadog_metrics` sink should be removed.
* legacy_openssl_provider v0.34.0 OpenSSL legacy provider flag should be removed
* armv7_rpm v0.34.0 The armv7 RPM packages should be removed (replaced by armv7hl)

### 0.35.0
* `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` internal metrics
16 changes: 16 additions & 0 deletions website/content/en/highlights/2023-11-07-0-34-0-upgrade-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ Vector's 0.34.0 release includes **breaking changes**:
1. [Removal of Deprecated Datadog Component Config Options](#datadog-deprecated-config-options)
1. [Removal of Deprecated `component_name` Metric Tag](#deprecated-component-name)

and **deprecations**:

1. [Deprecation of `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` Internal Metrics](#deprcate-obsolete-http-metrics)
Fixed Show fixed Hide fixed
dsmith3197 marked this conversation as resolved.
Show resolved Hide resolved

We cover them below to help you upgrade quickly:

## Upgrade guide
Expand All @@ -31,3 +35,15 @@ been removed from the Enterprise configuration. Instead of `region`, `site` shou
#### Removal of Deprecated `component_name` Metric Tag {#deprecated-component-name}

The deprecated `component_name` tag has been removed from all internal metrics. Instead the `component_id` tag should be used.

### Deprecations

#### Deprecation of `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` Internal Metrics {#deprcate-obsolete-http-metrics}
Fixed Show fixed Hide fixed
dsmith3197 marked this conversation as resolved.
Show resolved Hide resolved

The `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` internal metrics will be removed in the 0.35.0 release.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will they be replaced with anything? Or we just don't think they are valuable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the replacements are provided in the table below.

dsmith3197 marked this conversation as resolved.
Show resolved Hide resolved

| Deprecated Metric | Replacement Metric | Affected Components |
dsmith3197 marked this conversation as resolved.
Show resolved Hide resolved
|-----------------------------|-------------------------------------|------------------------------------------------------------------------------------------|
| requests_completed_total | http_client_responses_total | apache metrics, aws ecs metrics, http client, prometheus remote write, prometheus scrape |
| request_duration_seconds | http_client_response_rtt_seconds | apache metrics, aws ecs metrics, http client, prometheus remote write, prometheus scrape |
| requests_received_total | http_server_requests_received_total | aws kinesis firehose, heroku logplex, prometheus exporter, splunk hec |