Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(releasing): Prepare v0.34.0 release #19049

Merged
merged 1 commit into from
Nov 7, 2023
Merged

chore(releasing): Prepare v0.34.0 release #19049

merged 1 commit into from
Nov 7, 2023

Conversation

jszwedko
Copy link
Member

@jszwedko jszwedko commented Nov 3, 2023

@github-actions github-actions bot added domain: releasing Anything related to releasing Vector domain: external docs Anything related to Vector's external, public documentation labels Nov 3, 2023
@jszwedko jszwedko force-pushed the prepare-v0.34.0 branch 3 times, most recently from e7dc34e to 7d5ed3b Compare November 6, 2023 14:54
@jszwedko jszwedko marked this pull request as ready for review November 6, 2023 14:54
@jszwedko jszwedko requested review from a team as code owners November 6, 2023 14:54
@jszwedko

This comment was marked as outdated.

@jszwedko
Copy link
Member Author

jszwedko commented Nov 6, 2023

/ci-run-all

@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Nov 6, 2023

Datadog Report

Branch report: prepare-v0.34.0
Commit report: 5e1494c

vector: 0 Failed, 0 New Flaky, 2002 Passed, 0 Skipped, 1m 20.71s Wall Time

website/cue/reference/releases/0.34.0.cue Outdated Show resolved Hide resolved
website/cue/reference/releases/0.34.0.cue Outdated Show resolved Hide resolved
website/cue/reference/releases/0.34.0.cue Outdated Show resolved Hide resolved
website/cue/reference/releases/0.34.0.cue Outdated Show resolved Hide resolved
website/cue/reference/releases/0.34.0.cue Outdated Show resolved Hide resolved
website/cue/reference/releases/0.34.0.cue Outdated Show resolved Hide resolved
Copy link
Contributor

@dsmith3197 dsmith3197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me overall after comments are addressed.

website/cue/reference/releases/0.34.0.cue Outdated Show resolved Hide resolved
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions!

website/cue/reference/releases/0.34.0.cue Outdated Show resolved Hide resolved
website/cue/reference/releases/0.34.0.cue Outdated Show resolved Hide resolved
website/cue/reference/releases/0.34.0.cue Outdated Show resolved Hide resolved
website/cue/reference/releases/0.34.0.cue Outdated Show resolved Hide resolved
website/cue/reference/releases/0.34.0.cue Outdated Show resolved Hide resolved
website/cue/reference/releases/0.34.0.cue Outdated Show resolved Hide resolved
website/cue/reference/releases/0.34.0.cue Outdated Show resolved Hide resolved
website/cue/reference/releases/0.34.0.cue Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Nov 6, 2023

Regression Detector Results

Run ID: 80a46422-2a3a-47ef-a9b4-7af50a405cdc
Baseline: 7a16ee2
Comparison: bd318c0
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

  1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

  2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean % Δ mean % CI confidence
http_to_http_acks ingress throughput +1.75 [+0.43, +3.07] 97.09%
splunk_hec_route_s3 ingress throughput +1.25 [+0.74, +1.77] 99.99%
syslog_splunk_hec_logs ingress throughput +1.03 [+0.99, +1.07] 100.00%
syslog_log2metric_humio_metrics ingress throughput +0.53 [+0.41, +0.64] 100.00%
syslog_regex_logs2metric_ddmetrics ingress throughput +0.37 [+0.27, +0.46] 100.00%
http_text_to_http_json ingress throughput +0.31 [+0.19, +0.44] 100.00%
file_to_blackhole egress throughput +0.31 [-2.15, +2.76] 16.31%
fluent_elasticsearch ingress throughput +0.27 [-0.16, +0.71] 69.48%
http_to_http_noack ingress throughput +0.13 [+0.06, +0.21] 99.66%
socket_to_socket_blackhole ingress throughput +0.09 [+0.02, +0.16] 96.61%
http_to_http_json ingress throughput -0.00 [-0.07, +0.07] 1.15%
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.14, +0.14] 0.73%
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.15, +0.14] 1.13%
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.05 [-0.17, +0.06] 56.02%
syslog_log2metric_splunk_hec_metrics ingress throughput -0.08 [-0.20, +0.04] 70.82%
http_to_s3 ingress throughput -0.13 [-0.41, +0.15] 54.75%
enterprise_http_to_http ingress throughput -0.14 [-0.22, -0.07] 99.78%
datadog_agent_remap_blackhole ingress throughput -0.20 [-0.29, -0.12] 99.99%
datadog_agent_remap_blackhole_acks ingress throughput -0.20 [-0.29, -0.11] 99.98%
syslog_loki ingress throughput -0.35 [-0.39, -0.32] 100.00%
otlp_grpc_to_blackhole ingress throughput -0.63 [-0.72, -0.53] 100.00%
datadog_agent_remap_datadog_logs ingress throughput -0.63 [-0.73, -0.54] 100.00%
otlp_http_to_blackhole ingress throughput -0.72 [-0.88, -0.56] 100.00%
datadog_agent_remap_datadog_logs_acks ingress throughput -0.76 [-0.84, -0.68] 100.00%
syslog_humio_logs ingress throughput -1.04 [-1.13, -0.96] 100.00%

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@jszwedko jszwedko merged commit c909b66 into v0.34 Nov 7, 2023
73 checks passed
@jszwedko jszwedko deleted the prepare-v0.34.0 branch November 7, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation domain: releasing Anything related to releasing Vector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants