chore: Upgrade lib/codec to tokio-util 0.2 and bytes 0.5 #1935
+99
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MOZGIII <mike-n@narod.ru>
|
What is the reason to upgrade this now, I don't think this will compile with our sources/sinks? |
|
You're right. It was just a part of my early experimentation I did when I started with the futures/tokio update. At this point, according to our plan this should happen much later. But I had this code done before, and decided to upload it - it might still end up saving us some time later. |
|
Closing since this has become outdated. We'll also be upgrading incrementally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only includes the
lib/codecupdate so far, but doesn't have an integration into mainvectorcrate. Tests will fail, code won't build.The reason is there's a complication with file sink - the sole consumer of this code. I've implemented it on Monday, but wasn't able to move further, and it looks like the integration of this change has to be postponed until we migrate file sink.