Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use fasyslog for creating syslog payload #22603

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tisonkun
Copy link

@tisonkun tisonkun commented Mar 6, 2025

This closes #20955.

Somehow self-promoted and I'm actively maintaining fasyslog. I'd appreciate it if you can give a review and see whether we can go in this way.

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun requested a review from a team as a code owner March 6, 2025 09:46
@bits-bot
Copy link

bits-bot commented Mar 6, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Mar 6, 2025
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Author

cc @jszwedko

@pront
Copy link
Member

pront commented Mar 10, 2025

cc @jszwedko

Hi @tisonkun, we will taking a look at this PR. Thank you for submitting this. There's a big backlog so it takes a bit longer than usual. Generally, for future PRs (and in case someone from the community reads this) please ping @vectordotdev/vector.

@tisonkun
Copy link
Author

@pront Thanks for your information!

It seems @vectordotdev/vector is not a team? Since it's not in bold I'm not sure if the notification is sent.

BTW, could you trigger the CI workflow so that I can check if any trivial issues should be fixed?

@pront
Copy link
Member

pront commented Mar 11, 2025

It seems @vectordotdev/vector is not a team? Since it's not in bold I'm not sure if the notification is sent.

Interesting, thanks for letting me know:

image

BTW, could you trigger the CI workflow so that I can check if any trivial issues should be fixed?

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sinks Anything related to the Vector's sinks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants