perf: start removing Atom from the hot path #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
LucioFranco
approved these changes
Apr 10, 2020
|
/test -t tcp_to_tcp_performance |
|
I'm going to merge with the one approval for now, but please do still review when you get a chance 😄 |
|
Test harness invocation requested by #2295 (comment) is complete! Something went wrong, see log for more details. You can check the execution log to learn more! |
binarylogic
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1891
This removes
Atomfrom our data model and thegrok_parsertransform. We can follow up with similar changes to other components, but this was sufficient for a ~15% throughput increase in a simple grok-heavy pipeline.I also removed some unused methods
*_flatthat kept catching my eye for looking slow. Let me know if we should keep these around for any reason @a-rodin.