Skip to content

Conversation

@anil-db
Copy link
Contributor

@anil-db anil-db commented Oct 28, 2025

Summary

current fix process all file changes during delay period but if 2 event one for component change and one for config update happen in that duration file upload change is ignored.

this PR fix it but checking if there was file update not matching to any component this would have cause reload to disk in past.
in tat case prefer reload to disk.

Vector configuration

How did you test this PR?

added unit tests.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details here.

@anil-db anil-db requested a review from a team as a code owner October 28, 2025 21:08
@anil-db anil-db force-pushed the handle-watch-events branch from 26f764e to 8fd71ca Compare October 28, 2025 21:10
@pront
Copy link
Member

pront commented Oct 29, 2025

Hi @anil-db, is there an open bug report for this?
Please take a look at failing checks.

@pront pront added the meta: awaiting author Pull requests that are awaiting their author. label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta: awaiting author Pull requests that are awaiting their author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants