-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Build docker compose images nightly and use them in CI #2579
Conversation
The rest of the CI failures are actual errors that went undetected with the current CI setup. Let's merge this and fix the errors in other PRs. |
0f655c6
to
eccffa6
Compare
This PR still has one failing job - the |
49c16ee
to
6a36ff4
Compare
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
…script Signed-off-by: MOZGIII <mike-n@narod.ru>
…thout docker Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
19.04 is deprecated and is not longer updated at Docker Hub. 20.04, in turn, in the fresh latest LTS release. Signed-off-by: MOZGIII <mike-n@narod.ru>
Signed-off-by: MOZGIII <mike-n@narod.ru>
This is blocked by #2618 |
Is this still relevant @MOZGIII ? |
The PR - definitely not. We might still want to build an environment image every night though. |
This is an attempt to finally streamline the CI and ensure we have quick builds in CI and a unified environment configs across local and CI tasks.
To make things work, I had to introduce the following changes:
docker-compose.yml
While working on this, I uncovered a few issues that I'm not planning on solving in this PR:
Dockerfile
s are not cache-friendly, we should correct thisdocker-compose.yml
,Makefile
and.github/workflow/code.yml
each contains configuration for the same "unit"s, but it's all coded separately; there's way too much attention required to implement keep things in order and consistent, and it's hard to maintain; we should revisit the approach, and root all those places in a single source of truth