enhancement(external docs): Add Cue docs for component-specific metrics #4820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucperkins
force-pushed
the
internal-metrics-docs
branch
2 times, most recently
from
2e6a49d
to
b5430b1
Compare
binarylogic
reviewed
Nov 1, 2020
|
Seems like a good start, but we're missing quite a few. Ex: Finally, I think we'll want to note which metrics are available based on which components. So, for example, the |
|
@binarylogic Sorry, thought I had marked this PR as a draft. It's indeed not there yet. |
lucperkins
force-pushed
the
internal-metrics-docs
branch
3 times, most recently
from
16fd43e
to
f8c47a2
Compare
|
@binarylogic I thought about it, and I think the way to go here is to define all of the potential metrics "lower" in the config tree as a kind of grab bag, potentially split into groups for convenience, that each component can draw from. That will enable us to have per-component granularity while also using the good parts of Cue to full effect. |
lucperkins
force-pushed
the
internal-metrics-docs
branch
5 times, most recently
from
11adc2a
to
42277e6
Compare
lucperkins
force-pushed
the
internal-metrics-docs
branch
from
03e701f
to
824db8d
Compare
binarylogic
reviewed
Nov 5, 2020
lucperkins
force-pushed
the
internal-metrics-docs
branch
8 times, most recently
from
41acffc
to
42c2f08
Compare
lucperkins
requested review from
bruceg,
fanatid and
StephenWakely
as code owners
lucperkins
force-pushed
the
internal-metrics-docs
branch
4 times, most recently
from
599c325
to
462f6ea
Compare
added 19 commits
November 19, 2020 11:12
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
Signed-off-by: Luc Perkins <luc@timber.io>
lucperkins
force-pushed
the
internal-metrics-docs
branch
from
462f6ea
to
9169269
Compare
Signed-off-by: Luc Perkins <luc@timber.io>
casserni
pushed a commit
that referenced
this pull request
Nov 20, 2020
…cs (#4820) * Begin transferring metrics Signed-off-by: Luc Perkins <luc@timber.io> * Metrics docs for sinks Signed-off-by: Luc Perkins <luc@timber.io> * Add source metrics and refactor metrics.cue Signed-off-by: Luc Perkins <luc@timber.io> * Add metrics for transforms Signed-off-by: Luc Perkins <luc@timber.io> * Fill in remaining TODO descriptions Signed-off-by: Luc Perkins <luc@timber.io> * Add internal_metrics source Signed-off-by: Luc Perkins <luc@timber.io> * Fix service/aggregator discrepancy Signed-off-by: Luc Perkins <luc@timber.io> * Move Apache, MongoDB, and host metrics out of metrics.cue Signed-off-by: Luc Perkins <luc@timber.io> * Move Docker metrics out of metrics.cue Signed-off-by: Luc Perkins <luc@timber.io> * Move k8s metrics out of metrics.cue Signed-off-by: Luc Perkins <luc@timber.io> * Migrate internal metrics out of metrics.cue Signed-off-by: Luc Perkins <luc@timber.io> * Remove metrics.cue file Signed-off-by: Luc Perkins <luc@timber.io> * Apply explicit default namespace to all metrics Signed-off-by: Luc Perkins <luc@timber.io> * Refactor Splunk common metrics into separate file Signed-off-by: Luc Perkins <luc@timber.io> * Address feedback on metric descriptions Signed-off-by: Luc Perkins <luc@timber.io> * Add default namespace to AWS ECS metrics Signed-off-by: Luc Perkins <luc@timber.io> * Add _total suffix to Windows metrics Signed-off-by: Luc Perkins <luc@timber.io> * Add new options for the error_type tag Signed-off-by: Luc Perkins <luc@timber.io> * Add AWS S3+SQS metrics to docs Signed-off-by: Luc Perkins <luc@timber.io> * Refactor all vector namespace metrics into internal_metrics.cue Signed-off-by: Luc Perkins <luc@timber.io> Signed-off-by: casserni <nicholascassera@gmail.com>
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
…cs (vectordotdev#4820) * Begin transferring metrics Signed-off-by: Luc Perkins <luc@timber.io> * Metrics docs for sinks Signed-off-by: Luc Perkins <luc@timber.io> * Add source metrics and refactor metrics.cue Signed-off-by: Luc Perkins <luc@timber.io> * Add metrics for transforms Signed-off-by: Luc Perkins <luc@timber.io> * Fill in remaining TODO descriptions Signed-off-by: Luc Perkins <luc@timber.io> * Add internal_metrics source Signed-off-by: Luc Perkins <luc@timber.io> * Fix service/aggregator discrepancy Signed-off-by: Luc Perkins <luc@timber.io> * Move Apache, MongoDB, and host metrics out of metrics.cue Signed-off-by: Luc Perkins <luc@timber.io> * Move Docker metrics out of metrics.cue Signed-off-by: Luc Perkins <luc@timber.io> * Move k8s metrics out of metrics.cue Signed-off-by: Luc Perkins <luc@timber.io> * Migrate internal metrics out of metrics.cue Signed-off-by: Luc Perkins <luc@timber.io> * Remove metrics.cue file Signed-off-by: Luc Perkins <luc@timber.io> * Apply explicit default namespace to all metrics Signed-off-by: Luc Perkins <luc@timber.io> * Refactor Splunk common metrics into separate file Signed-off-by: Luc Perkins <luc@timber.io> * Address feedback on metric descriptions Signed-off-by: Luc Perkins <luc@timber.io> * Add default namespace to AWS ECS metrics Signed-off-by: Luc Perkins <luc@timber.io> * Add _total suffix to Windows metrics Signed-off-by: Luc Perkins <luc@timber.io> * Add new options for the error_type tag Signed-off-by: Luc Perkins <luc@timber.io> * Add AWS S3+SQS metrics to docs Signed-off-by: Luc Perkins <luc@timber.io> * Refactor all vector namespace metrics into internal_metrics.cue Signed-off-by: Luc Perkins <luc@timber.io> Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4810 by adding Cue configs for the
internal_metricssource. This PR also restructures the metrics into a singlemetrics.cuefile and adds atelemetry.metricsblock to all components to which that applies.